From 871b9b1f6f8ae26ffc957027ee92faa720608946 Mon Sep 17 00:00:00 2001 From: manuroe Date: Fri, 20 Sep 2019 17:21:00 +0200 Subject: [PATCH] VoiceOver: Make ScrollToBottomButton speakable --- Riot/Assets/en.lproj/Vector.strings | 1 + Riot/Generated/Strings.swift | 4 ++++ Riot/Modules/Room/Views/Activities/RoomActivitiesView.m | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/Riot/Assets/en.lproj/Vector.strings b/Riot/Assets/en.lproj/Vector.strings index 8d1dd18f4..f26a6b6b6 100644 --- a/Riot/Assets/en.lproj/Vector.strings +++ b/Riot/Assets/en.lproj/Vector.strings @@ -250,6 +250,7 @@ // Chat "room_jump_to_first_unread" = "Jump to first unread message"; +"room_accessiblity_scroll_to_bottom" = "Scroll to bottom"; "room_new_message_notification" = "%d new message"; "room_new_messages_notification" = "%d new messages"; "room_one_user_is_typing" = "%@ is typing…"; diff --git a/Riot/Generated/Strings.swift b/Riot/Generated/Strings.swift index 3dd8ff2b2..55da09c78 100644 --- a/Riot/Generated/Strings.swift +++ b/Riot/Generated/Strings.swift @@ -1506,6 +1506,10 @@ internal enum VectorL10n { internal static var roomAccessibilityUpload: String { return VectorL10n.tr("Vector", "room_accessibility_upload") } + /// Scroll to bottom + internal static var roomAccessiblityScrollToBottom: String { + return VectorL10n.tr("Vector", "room_accessiblity_scroll_to_bottom") + } /// Take photo or video internal static var roomActionCamera: String { return VectorL10n.tr("Vector", "room_action_camera") diff --git a/Riot/Modules/Room/Views/Activities/RoomActivitiesView.m b/Riot/Modules/Room/Views/Activities/RoomActivitiesView.m index 6648db9b1..1baaf2079 100644 --- a/Riot/Modules/Room/Views/Activities/RoomActivitiesView.m +++ b/Riot/Modules/Room/Views/Activities/RoomActivitiesView.m @@ -307,6 +307,11 @@ self.iconImageView.image = [UIImage imageNamed:@"scrolldown"]; } self.iconImageView.hidden = NO; + + // Make VoiceOver consider it as a button + self.iconImageView.accessibilityLabel = NSLocalizedStringFromTable(@"room_accessiblity_scroll_to_bottom", @"Vector", nil); + self.iconImageView.isAccessibilityElement = YES; + self.iconImageView.accessibilityTraits = UIAccessibilityTraitButton; if (onIconTapGesture) {