From a5760bc770a184b26162318381428c240d8cb5fa Mon Sep 17 00:00:00 2001 From: manuroe Date: Mon, 29 Jul 2019 17:31:07 +0200 Subject: [PATCH] BF: Crash when leaving settings due to backup section refresh animation. The exception was: *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 10. The number of rows contained in an existing section after the update (0) must be equal to the number of rows contained in that section before the update (3), plus or minus the number of rows inserted or deleted from that section (0 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).' To raise this exception: - Execute the removed code after a delay (2s) - Enter and leave the settings page -> Crash --- CHANGES.rst | 3 +++ Riot/Modules/Settings/SettingsViewController.m | 5 +---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 34b9390db..0786638f6 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -6,6 +6,9 @@ Improvements: * Soft logout: Support soft logout (#2540). * Reactions: Emoji picker (#2370). +Bug fix: +* Crash when leaving settings due to backup section refresh animation. + Changes in 0.9.1 (2019-07-17) =============================================== diff --git a/Riot/Modules/Settings/SettingsViewController.m b/Riot/Modules/Settings/SettingsViewController.m index b8e545a09..091cb5d20 100644 --- a/Riot/Modules/Settings/SettingsViewController.m +++ b/Riot/Modules/Settings/SettingsViewController.m @@ -4269,10 +4269,7 @@ SignOutAlertPresenterDelegate> - (void)settingsKeyBackupTableViewSectionDidUpdate:(SettingsKeyBackupTableViewSection *)settingsKeyBackupTableViewSection { - [self.tableView beginUpdates]; - [self.tableView reloadSections:[NSIndexSet indexSetWithIndex:SETTINGS_SECTION_KEYBACKUP_INDEX] - withRowAnimation:UITableViewRowAnimationAutomatic]; - [self.tableView endUpdates]; + [self.tableView reloadData]; } - (MXKTableViewCellWithTextView *)settingsKeyBackupTableViewSection:(SettingsKeyBackupTableViewSection *)settingsKeyBackupTableViewSection textCellForRow:(NSInteger)textCellForRow