Matrix/element-ios
Matrix/element-ios
1
0
Fork 0
mirror of https://github.com/vector-im/element-ios.git synced 2024-09-28 23:32:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Prevent crash when searching

Browse source
This commit is contained in:
Andy Uhnak 2022-05-03 18:46:30 +01:00
parent 0bc1a79b25
commit d179cd81d2
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Riot/Modules/Common/Recents/RecentsViewController.m
View file

@ -1088,8 +1088,12 @@ NSString *const RecentsViewControllerDataReadyNotification = @"RecentsViewContro
}
else
{
MXLogDebug(@"[RecentsViewController]: Reloading table view section %ld", indexPath.section);
[self.recentsTableView reloadSections:[NSIndexSet indexSetWithIndex:indexPath.section] withRowAnimation:UITableViewRowAnimationNone];
// Ideally we would call tableView.reloadSections, but this can lead to crashes if multiple sections need such an update and they
// vertically depend on each other. It is unclear whether this is due to further issues in the data model (e.g. data race)
// or some undocumented table view behavior. To avoid this we reload the entire table view, even if this means reloading
// multiple times for several section updates.
MXLogDebug(@"[RecentsViewController]: Reloading the entire table view due to updates in section %ld", indexPath.section);
[self refreshRecentsTable];
}
}
else if (!changes)

1
changelog.d/6115.bugfix Normal file
View file

@ -0,0 +1 @@
Search: Prevent crash when searching