From fc73ee762b2e15f706690c984f8a14aa78c0c56d Mon Sep 17 00:00:00 2001 From: Doug Date: Mon, 23 Aug 2021 12:38:04 +0100 Subject: [PATCH] Add comments about memory constraints. --- RiotShareExtension/Managers/ShareExtensionManager.m | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/RiotShareExtension/Managers/ShareExtensionManager.m b/RiotShareExtension/Managers/ShareExtensionManager.m index ac461c475..c91d563ed 100644 --- a/RiotShareExtension/Managers/ShareExtensionManager.m +++ b/RiotShareExtension/Managers/ShareExtensionManager.m @@ -323,8 +323,9 @@ typedef NS_ENUM(NSInteger, ImageCompressionMode) dispatch_group_leave(requestsGroup); } - // Only prompt for image resize if all items are images and the setting is enabled. - if (RiotSettings.shared.showMediaCompressionPrompt && areAllAttachmentsImages) + // Only prompt for image resize if all items are images + // Ignore showMediaCompressionPrompt setting due to memory constraints with full size images. + if (areAllAttachmentsImages) { if ([self areAttachmentsFullyLoaded]) { @@ -1157,6 +1158,7 @@ typedef NS_ENUM(NSInteger, ImageCompressionMode) MXWeakify(self); + // Ignore showMediaCompressionPrompt setting due to memory constraints when encrypting large videos. UIAlertController *compressionPrompt = [MXKTools videoConversionPromptForVideoAsset:videoAsset withCompletion:^(NSString * _Nullable presetName) { MXStrongifyAndReturnIfNil(self);