From 3198cf26b418be934601e26cdd172e00e175ac51 Mon Sep 17 00:00:00 2001 From: Robin Date: Wed, 12 Jun 2024 11:42:15 -0400 Subject: [PATCH] Use latest LTS Node in CI The README says we require the latest LTS version of Node, but actions/setup-node with ubuntu-latest appears to default to a version earlier than that. I'd like to make use of a feature (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicodeSets) available only since Node 20, which happens to be the latest LTS. So, let's get CI on the right version. --- .github/workflows/build.yml | 1 + .github/workflows/build_develop.yml | 1 + .github/workflows/docs.yml | 1 + .github/workflows/static_analysis.yaml | 5 +++++ .github/workflows/tests.yaml | 1 + .github/workflows/update-jitsi.yml | 1 + 6 files changed, 10 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b6924528f6..be1eff0edc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,6 +36,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" # Workaround for yarn install timeouts, especially on Windows diff --git a/.github/workflows/build_develop.yml b/.github/workflows/build_develop.yml index 96b96c8398..6483f2c301 100644 --- a/.github/workflows/build_develop.yml +++ b/.github/workflows/build_develop.yml @@ -25,6 +25,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" - name: Install Dependencies diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index e495e87eaa..c1db65161b 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -44,6 +44,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" cache-dependency-path: element-web/yarn.lock diff --git a/.github/workflows/static_analysis.yaml b/.github/workflows/static_analysis.yaml index 2caa342b6b..5a97454ecc 100644 --- a/.github/workflows/static_analysis.yaml +++ b/.github/workflows/static_analysis.yaml @@ -20,6 +20,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" - name: Install Dependencies @@ -42,6 +43,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" # Does not need branch matching as only analyses this layer @@ -59,6 +61,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" # Needs branch matching as it inherits .stylelintrc.js from matrix-react-sdk @@ -76,6 +79,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" # Does not need branch matching as only analyses this layer @@ -93,6 +97,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" - name: Install Deps diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index b654b2a3a2..5452d5f351 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -22,6 +22,7 @@ jobs: - name: Yarn cache uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" - name: Install Dependencies diff --git a/.github/workflows/update-jitsi.yml b/.github/workflows/update-jitsi.yml index 10a082cf24..44c47b81f2 100644 --- a/.github/workflows/update-jitsi.yml +++ b/.github/workflows/update-jitsi.yml @@ -12,6 +12,7 @@ jobs: - uses: actions/setup-node@v4 with: + node-version: lts/* # Latest LTS cache: "yarn" - name: Install Deps