Apply suggestions from code review

This commit is contained in:
J. Ryan Stinnett 2020-08-19 18:18:50 +01:00 committed by GitHub
parent 993fd04353
commit 8cfb0a71a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -52,20 +52,20 @@ default, and you are using riot-web 1.6 or newer, set the following on your home
## Element Android ## Element Android
Element Android (1.0.5+) supports custom jitsi domain. Element Android (1.0.5+) supports custom Jitsi domains, similar to Element Web above.
1:1 calls, or calls between you and one other person, do not use Jitsi. Instead, those 1:1 calls, or calls between you and one other person, do not use Jitsi. Instead, those
calls work directly between clients or via TURN servers configured on the respective calls work directly between clients or via TURN servers configured on the respective
homeservers. homeservers.
For rooms with more than 2 joined members, when creating a jitsi conference via call/video buttons of the toolbar (not via integration manager), Element Android will create a widget using app.element.io [wrapper](https://github.com/vector-im/element-web/blob/develop/docs/jitsi-dev.md) as url. For rooms with more than 2 joined members, when creating a Jitsi conference via call/video buttons of the toolbar (not via integration manager), Element Android will create a widget using the [wrapper](https://github.com/vector-im/element-web/blob/develop/docs/jitsi-dev.md) hosted on `app.element.io`.
The domain used is the one specified by the `/.well-known/matrix/client` endpoint, and if not present it uses the fallback defined in `confix.xml` (jitsi.riot.im) The domain used is the one specified by the `/.well-known/matrix/client` endpoint, and if not present it uses the fallback defined in `config.xml` (jitsi.riot.im)
For active jitsi widgets in the room, a native jitsi widget UI is created and points to the instance specified in the `domain` key of the widget content data. For active Jitsi widgets in the room, a native Jitsi widget UI is created and points to the instance specified in the `domain` key of the widget content data.
Element android manages allowed native widgets permissions a bit differently than web widgets (as the data shared are different, and never shared with the widget url). For jitsi widgets permissions is asked only once per domain (consent saved in account data). Element Android manages allowed native widgets permissions a bit differently than web widgets (as the data shared are different and never shared with the widget URL). For Jitsi widgets, permissions are requested only once per domain (consent saved in account data).
## Element IOS ## Element iOS
Currently the Element mobile apps do not support custom Jitsi servers and will instead Currently the Element mobile apps do not support custom Jitsi servers and will instead
use the default `jitsi.riot.im` server. When users on the mobile apps join the call, use the default `jitsi.riot.im` server. When users on the mobile apps join the call,