mirror of
https://github.com/vector-im/element-web.git
synced 2024-09-10 07:05:14 +00:00
Move multi-repo linking to workflow section
This commit is contained in:
parent
1aecc3d7e5
commit
bd8b3a9046
1 changed files with 3 additions and 3 deletions
|
@ -37,12 +37,12 @@ When reviewing code, here are some things we look for and also things we avoid:
|
||||||
* Take the time to thank and point out good code changes
|
* Take the time to thank and point out good code changes
|
||||||
* Using softer language like "please" and "what do you think?" goes a long way
|
* Using softer language like "please" and "what do you think?" goes a long way
|
||||||
towards making others feel like colleagues working towards a common goal
|
towards making others feel like colleagues working towards a common goal
|
||||||
* Authors should link to other layers of their PR in their PR before requesting
|
|
||||||
review. Reviewers might be coming from different places and could miss other
|
|
||||||
required PRs.
|
|
||||||
|
|
||||||
### Workflow
|
### Workflow
|
||||||
|
|
||||||
|
* Authors should link to other layers of their PR in their PR before requesting
|
||||||
|
review. Reviewers might be coming from different places and could miss other
|
||||||
|
required PRs.
|
||||||
* Avoid force pushing to a PR after first round of review
|
* Avoid force pushing to a PR after first round of review
|
||||||
* Use merge commits when landing
|
* Use merge commits when landing
|
||||||
* PR author merges after review (assuming they have write access)
|
* PR author merges after review (assuming they have write access)
|
||||||
|
|
Loading…
Reference in a new issue