Matrix/synapse
Matrix/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse synced 2024-06-30 18:23:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the bug accidentally nesting lists

Browse source
This commit is contained in:
Eric Eastwood 2022-09-30 01:21:23 -05:00
parent 0e51535442
commit 1268b7989c
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
synapse/handlers/room_batch.py
View file

@ -154,7 +154,6 @@ class RoomBatchHandler:
state_events_at_start: List[JsonDict], state_events_at_start: List[JsonDict],
room_id: str, room_id: str,
initial_prev_event_ids: List[str], initial_prev_event_ids: List[str],
initial_state_event_ids: List[str],
app_service_requester: Requester, app_service_requester: Requester,
) -> List[str]: ) -> List[str]:
"""Takes all `state_events_at_start` event dictionaries and creates/persists """Takes all `state_events_at_start` event dictionaries and creates/persists
@ -178,7 +177,7 @@ class RoomBatchHandler:
# Connect the state chain to the prev_events we're insertin next to # Connect the state chain to the prev_events we're insertin next to
# so that they are valid events and don't get rejected. # so that they are valid events and don't get rejected.
prev_event_ids_for_state_chain: List[str] = [initial_prev_event_ids] prev_event_ids_for_state_chain: List[str] = initial_prev_event_ids
for index, state_event in enumerate(state_events_at_start): for index, state_event in enumerate(state_events_at_start):
assert_params_in_dict( assert_params_in_dict(
@ -213,9 +212,6 @@ class RoomBatchHandler:
action=membership, action=membership,
content=event_dict["content"], content=event_dict["content"],
historical=True, historical=True,
# Only the first event in the state chain should be floating.
# The rest should hang off each other in a chain.
allow_no_prev_events=index == 0,
prev_event_ids=prev_event_ids_for_state_chain, prev_event_ids=prev_event_ids_for_state_chain,
) )
else: else:
@ -228,9 +224,6 @@ class RoomBatchHandler:
), ),
event_dict, event_dict,
historical=True, historical=True,
# Only the first event in the state chain should be floating.
# The rest should hang off each other in a chain.
allow_no_prev_events=index == 0,
prev_event_ids=prev_event_ids_for_state_chain, prev_event_ids=prev_event_ids_for_state_chain,
) )
event_id = event.event_id event_id = event.event_id