Matrix/synapse
Matrix/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse synced 2024-07-02 10:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix spurious warning when fetching state after a missing prev event (#13258)

Browse source
This commit is contained in:
Sean Quah 2022-07-19 19:15:54 +01:00 committed by GitHub
parent a6895dd576
commit 172ce29b14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/13258.misc Normal file
View file

@ -0,0 +1 @@
Fix spurious warning when fetching state after a missing prev event.

3
synapse/handlers/federation_event.py
View file

@ -1037,6 +1037,9 @@ class FederationEventHandler:
# XXX: this doesn't sound right? it means that we'll end up with incomplete
# state.
failed_to_fetch = desired_events - event_metadata.keys()
# `event_id` could be missing from `event_metadata` because it's not necessarily
# a state event. We've already checked that we've fetched it above.
failed_to_fetch.discard(event_id)
if failed_to_fetch:
logger.warning(
"Failed to fetch missing state events for %s %s",