From 21ca02c5ad2b030f3a3d76526690b23f40ef9412 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 24 Jun 2024 16:08:58 -0500 Subject: [PATCH] `newly_joined` vs `limited` already being tracked in a discussion See https://github.com/element-hq/synapse/pull/17320#discussion_r1646579623 if anything comes out of it. --- synapse/handlers/sliding_sync.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/synapse/handlers/sliding_sync.py b/synapse/handlers/sliding_sync.py index a6e84cb976..4d73134e7f 100644 --- a/synapse/handlers/sliding_sync.py +++ b/synapse/handlers/sliding_sync.py @@ -829,9 +829,6 @@ class SlidingSyncHandler: stream=timeline_events[0].internal_metadata.stream_ordering - 1 ) - # TODO: Does `newly_joined` affect `limited`? It does in sync v2 but I fail - # to understand why. - # Make sure we don't expose any events that the client shouldn't see timeline_events = await filter_events_for_client( self.storage_controllers,