From 303d834b78a7c93e390da3f426754cafff07c20f Mon Sep 17 00:00:00 2001
From: Eric Eastwood <eric.eastwood@beta.gouv.fr>
Date: Tue, 25 Jun 2024 12:38:09 -0500
Subject: [PATCH] Add tracking discussion for not optional in the future

---
 synapse/handlers/sliding_sync.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/synapse/handlers/sliding_sync.py b/synapse/handlers/sliding_sync.py
index e781080470..0538fddf84 100644
--- a/synapse/handlers/sliding_sync.py
+++ b/synapse/handlers/sliding_sync.py
@@ -756,6 +756,11 @@ class SlidingSyncHandler:
         """
 
         # Assemble the list of timeline events
+        #
+        # It would be nice to make the `rooms` response more uniform regardless of
+        # membership. Currently, we have to make all of these optional because
+        # `invite`/`knock` rooms only have `stripped_state`. See
+        # https://github.com/matrix-org/matrix-spec-proposals/pull/3575#discussion_r1653045932
         timeline_events: Optional[List[EventBase]] = None
         bundled_aggregations: Optional[Dict[str, BundledAggregations]] = None
         limited: Optional[bool] = None