Docker: only copy what we need to the build image (#4562)

There are two reasons this is a good thing:

 * first, it means that you don't end up with stuff kicking around your working
   copy ending up in the build image by mistake (which can upset the pip
   install process)

 * second: it means that the docker image cache is more effective, and we can
   reuse docker images when iterating on the docker stuff.
This commit is contained in:
Richard van der Hoff 2019-02-05 11:44:40 +00:00 committed by GitHub
parent bf1e4d96ad
commit 3ef71a6ea0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions

1
changelog.d/4562.misc Normal file
View file

@ -0,0 +1 @@
Docker: only copy what we need to the build image

View file

@ -31,7 +31,10 @@ RUN pip install --prefix="/install" --no-warn-script-location \
# now install synapse and all of the python deps to /install. # now install synapse and all of the python deps to /install.
COPY . /synapse COPY synapse /synapse/synapse/
COPY scripts /synapse/scripts/
COPY MANIFEST.in README.rst setup.py synctl /synapse/
RUN pip install --prefix="/install" --no-warn-script-location \ RUN pip install --prefix="/install" --no-warn-script-location \
/synapse[all] /synapse[all]