Merge pull request #946 from matrix-org/dbkr/log_recaptcha_hostname

Log the hostname the reCAPTCHA was completed on
This commit is contained in:
David Baker 2016-07-25 16:10:39 +01:00 committed by GitHub
commit 4fcdf7b4b2

View file

@ -279,7 +279,16 @@ class AuthHandler(BaseHandler):
data = pde.response
resp_body = simplejson.loads(data)
if 'success' in resp_body and resp_body['success']:
if 'success' in resp_body:
# Note that we do NOT check the hostname here: we explicitly
# intend the CAPTCHA to be presented by whatever client the
# user is using, we just care that they have completed a CAPTCHA.
logger.info(
"%s reCAPTCHA from hostname %s",
"Successful" if resp_body['success'] else "Failed",
resp_body.get('hostname')
)
if resp_body['success']:
defer.returnValue(True)
raise LoginError(401, "", errcode=Codes.UNAUTHORIZED)