Make room name optional

synapse/handlers/sliding_sync.py

@@ -879,8 +879,7 @@ class SlidingSyncHandler:
 
         return SlidingSyncResult.RoomResult(
             # TODO: Dummy value
-            # TODO: Make this optional because a computed name doesn't make sense for translated cases
-            name="TODO",
+            name=None,
             # TODO: Dummy value
             avatar=None,
             # TODO: Dummy value

synapse/rest/client/sync.py

@@ -990,7 +990,6 @@ class SlidingSyncRestServlet(RestServlet):
             )
 
             serialized_rooms[room_id] = {
-                "name": room_result.name,
                 "required_state": serialized_required_state,
                 "timeline": serialized_timeline,
                 "prev_batch": await room_result.prev_batch.to_string(self.store),
@@ -1002,6 +1001,9 @@ class SlidingSyncRestServlet(RestServlet):
                 "num_live": room_result.num_live,
             }
 
+            if room_result.name:
+                serialized_rooms[room_id]["name"] = room_result.name
+
             if room_result.avatar:
                 serialized_rooms[room_id]["avatar"] = room_result.avatar
 

synapse/types/handlers/__init__.py

@@ -186,7 +186,7 @@ class SlidingSyncResult:
                 (with potentially other old events in the timeline).
         """
 
-        name: str
+        name: Optional[str]
         avatar: Optional[str]
         heroes: Optional[List[EventBase]]
         initial: bool