Matrix/synapse
Matrix/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse synced 2024-10-01 15:42:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

More clear way to express what membership we want to display

Browse source 
See https://github.com/element-hq/synapse/pull/17187#discussion_r1627754354
This commit is contained in:
Eric Eastwood 2024-06-05 10:54:26 -05:00
parent 2af467d4a8
commit 7bbe2ed8d8
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
synapse/handlers/sliding_sync.py
View file

@ -42,17 +42,6 @@ if TYPE_CHECKING:
logger = logging.getLogger(__name__)
# Everything except `Membership.LEAVE` because we want everything that's *still*
# relevant to the user. There are few more things to include in the sync response
# (kicks, newly_left) but those are handled separately.
MEMBERSHIP_TO_DISPLAY_IN_SYNC = (
Membership.INVITE,
Membership.JOIN,
Membership.KNOCK,
Membership.BAN,
)
def filter_membership_for_sync(*, membership: str, user_id: str, sender: str) -> bool:
"""
Returns True if the membership event should be included in the sync response,
@ -65,7 +54,10 @@ def filter_membership_for_sync(*, membership: str, user_id: str, sender: str) ->
"""
return (
membership in MEMBERSHIP_TO_DISPLAY_IN_SYNC
# Everything except `Membership.LEAVE` because we want everything that's *still*
# relevant to the user. There are few more things to include in the sync response
# (newly_left) but those are handled separately.
membership in (Membership.LIST - Membership.LEAVE)
# Include kicks
or (membership == Membership.LEAVE and sender != user_id)
)