Always dump logs from trial during CI. (#11068)

Instead of only dumping them if trial passes.
This commit is contained in:
Patrick Cloke 2021-10-12 16:09:49 -04:00 committed by GitHub
parent 988de0afb0
commit 8711e15734
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 0 deletions

View file

@ -122,6 +122,8 @@ jobs:
SYNAPSE_POSTGRES_USER: postgres SYNAPSE_POSTGRES_USER: postgres
SYNAPSE_POSTGRES_PASSWORD: postgres SYNAPSE_POSTGRES_PASSWORD: postgres
- name: Dump logs - name: Dump logs
# Logs are most useful when the command fails, always include them.
if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact # Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs # This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair # It also ignores find's exit code; this is a best effort affair
@ -146,6 +148,8 @@ jobs:
env: env:
TRIAL_FLAGS: "--jobs=2" TRIAL_FLAGS: "--jobs=2"
- name: Dump logs - name: Dump logs
# Logs are most useful when the command fails, always include them.
if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact # Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs # This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair # It also ignores find's exit code; this is a best effort affair
@ -176,6 +180,8 @@ jobs:
env: env:
TRIAL_FLAGS: "--jobs=2" TRIAL_FLAGS: "--jobs=2"
- name: Dump logs - name: Dump logs
# Logs are most useful when the command fails, always include them.
if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact # Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs # This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair # It also ignores find's exit code; this is a best effort affair

View file

@ -33,6 +33,8 @@ jobs:
TRIAL_FLAGS: "--jobs=2" TRIAL_FLAGS: "--jobs=2"
- name: Dump logs - name: Dump logs
# Logs are most useful when the command fails, always include them.
if: ${{ always() }}
# Note: Dumps to workflow logs instead of using actions/upload-artifact # Note: Dumps to workflow logs instead of using actions/upload-artifact
# This keeps logs colocated with failing jobs # This keeps logs colocated with failing jobs
# It also ignores find's exit code; this is a best effort affair # It also ignores find's exit code; this is a best effort affair

1
changelog.d/11068.misc Normal file
View file

@ -0,0 +1 @@
Always dump logs from unit tests during CI runs.