Remove special-case for twisted logger (#12589)

This was originally added when we first added a `MemoryHandler` to the default
log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure
that we didn't explode with an infinite loop if there was an error formatting
the logs.

Since then, we made additional improvements to logging which make this
workaround redundant. In particular:

 * we no longer attempt to log un-UTF8-decodable byte sequences, which were the
   most likely cause of an error in the first place.

 * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely
   case that there *is* an error, it won't cause an infinite loop.
This commit is contained in:
Richard van der Hoff 2022-04-29 22:05:18 +01:00 committed by GitHub
parent 57fac2a234
commit 8d156ec0ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 14 deletions

1
changelog.d/12589.misc Normal file
View file

@ -0,0 +1 @@
Remove special-case for `twisted` logger from default log config.

View file

@ -62,13 +62,6 @@ loggers:
# information such as access tokens. # information such as access tokens.
level: INFO level: INFO
twisted:
# We send the twisted logging directly to the file handler,
# to work around https://github.com/matrix-org/synapse/issues/3471
# when using "buffer" logger. Use "console" to log to stderr instead.
handlers: [file]
propagate: false
root: root:
level: INFO level: INFO

View file

@ -110,13 +110,6 @@ loggers:
# information such as access tokens. # information such as access tokens.
level: INFO level: INFO
twisted:
# We send the twisted logging directly to the file handler,
# to work around https://github.com/matrix-org/synapse/issues/3471
# when using "buffer" logger. Use "console" to log to stderr instead.
handlers: [file]
propagate: false
root: root:
level: INFO level: INFO