Add comment and TODO

This commit is contained in:
Erik Johnston 2017-05-05 10:59:32 +01:00
parent f346048a6e
commit b843631d71

View file

@ -426,6 +426,8 @@ class DeviceListEduUpdater(object):
# This can happen since we batch updates # This can happen since we batch updates
return return
# Given a list of updates we check if we need to resync. This
# happens if we've missed updates.
resync = yield self._need_to_do_resync(user_id, pending_updates) resync = yield self._need_to_do_resync(user_id, pending_updates)
if resync: if resync:
@ -434,6 +436,8 @@ class DeviceListEduUpdater(object):
try: try:
result = yield self.federation.query_user_devices(origin, user_id) result = yield self.federation.query_user_devices(origin, user_id)
except NotRetryingDestination: except NotRetryingDestination:
# TODO: Remember that we are now out of sync and try again
# later
logger.warn( logger.warn(
"Failed to handle device list update for %s," "Failed to handle device list update for %s,"
" we're not retrying the remote", " we're not retrying the remote",
@ -441,6 +445,8 @@ class DeviceListEduUpdater(object):
) )
return return
except Exception: except Exception:
# TODO: Remember that we are now out of sync and try again
# later
logger.exception( logger.exception(
"Failed to handle device list update for %s", user_id "Failed to handle device list update for %s", user_id
) )