From c8a240f59d7b00e00d51ad7a50f0b62ea1243134 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Tue, 11 Jun 2024 16:00:02 -0500 Subject: [PATCH] Prefer `? < a AND a <= ?` See https://github.com/element-hq/synapse/pull/17293#discussion_r1634863810 > FWIW I mildly prefer the styling `? < a AND a <= ?` as then my brain can more easily convert that to `a in (?...?]` --- synapse/storage/databases/main/stream.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/storage/databases/main/stream.py b/synapse/storage/databases/main/stream.py index 188bba0f1f..b02d42ac09 100644 --- a/synapse/storage/databases/main/stream.py +++ b/synapse/storage/databases/main/stream.py @@ -928,7 +928,7 @@ class StreamWorkerStore(EventsWorkerStore, SQLBaseStore): FROM events LEFT JOIN rejections USING (event_id) WHERE room_id = ? - AND stream_ordering > ? AND stream_ordering <= ? + AND ? < stream_ordering AND stream_ordering <= ? AND NOT outlier AND rejections.event_id IS NULL ORDER BY stream_ordering DESC