From d752b8ae196ba9392f2a910e23634fef2ab19229 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 10 Jun 2024 18:27:41 -0500 Subject: [PATCH] Comment no longer as useful Would be hard to craft a query to do all rooms at once since we have to query for rows between the min/max stream_ordering and filter on the client anyway. Would be easier if we could query for one thing for each room. --- synapse/handlers/sliding_sync.py | 1 - 1 file changed, 1 deletion(-) diff --git a/synapse/handlers/sliding_sync.py b/synapse/handlers/sliding_sync.py index 597a58e2df..7163f43c34 100644 --- a/synapse/handlers/sliding_sync.py +++ b/synapse/handlers/sliding_sync.py @@ -530,7 +530,6 @@ class SlidingSyncHandler: # Make a copy so we don't run into an error: `Set changed size during # iteration`, when we filter out and remove items for room_id in list(filtered_room_id_set): - # TODO: Is there a good method to look up all rooms at once? (N+1 query problem) state_at_to_token = await self.storage_controllers.state.get_state_at( room_id, to_token,