mirror of
https://github.com/element-hq/synapse
synced 2024-08-19 15:00:25 +00:00
deploy: 42786d8a47
This commit is contained in:
parent
b321257352
commit
d77783ca00
4 changed files with 14 additions and 12 deletions
|
@ -334,15 +334,16 @@ poetry lock --no-update
|
||||||
doesn't require poetry. (It's what we use in CI too). However, you could try
|
doesn't require poetry. (It's what we use in CI too). However, you could try
|
||||||
<code>poetry build</code> too.</p>
|
<code>poetry build</code> too.</p>
|
||||||
<h2 id="handle-a-dependabot-pull-request"><a class="header" href="#handle-a-dependabot-pull-request">...handle a Dependabot pull request?</a></h2>
|
<h2 id="handle-a-dependabot-pull-request"><a class="header" href="#handle-a-dependabot-pull-request">...handle a Dependabot pull request?</a></h2>
|
||||||
<p>Synapse uses Dependabot to keep the <code>poetry.lock</code> file up-to-date. When it
|
<p>Synapse uses Dependabot to keep the <code>poetry.lock</code> and <code>Cargo.lock</code> file
|
||||||
creates a pull request a GitHub Action will run to automatically create a changelog
|
up-to-date with the latest releases of our dependencies. The changelog check is
|
||||||
file. Ensure that:</p>
|
omitted for Dependabot PRs; the release script will include them in the
|
||||||
|
changelog.</p>
|
||||||
|
<p>When reviewing a dependabot PR, ensure that:</p>
|
||||||
<ul>
|
<ul>
|
||||||
<li>the lockfile changes look reasonable;</li>
|
<li>the lockfile changes look reasonable;</li>
|
||||||
<li>the upstream changelog file (linked in the description) doesn't include any
|
<li>the upstream changelog file (linked in the description) doesn't include any
|
||||||
breaking changes;</li>
|
breaking changes;</li>
|
||||||
<li>continuous integration passes (due to permissions, the GitHub Actions run on
|
<li>continuous integration passes.</li>
|
||||||
the changelog commit will fail, look at the initial commit of the pull request);</li>
|
|
||||||
</ul>
|
</ul>
|
||||||
<p>In particular, any updates to the type hints (usually packages which start with <code>types-</code>)
|
<p>In particular, any updates to the type hints (usually packages which start with <code>types-</code>)
|
||||||
should be safe to merge if linting passes.</p>
|
should be safe to merge if linting passes.</p>
|
||||||
|
|
|
@ -17056,15 +17056,16 @@ poetry lock --no-update
|
||||||
doesn't require poetry. (It's what we use in CI too). However, you could try
|
doesn't require poetry. (It's what we use in CI too). However, you could try
|
||||||
<code>poetry build</code> too.</p>
|
<code>poetry build</code> too.</p>
|
||||||
<h2 id="handle-a-dependabot-pull-request"><a class="header" href="#handle-a-dependabot-pull-request">...handle a Dependabot pull request?</a></h2>
|
<h2 id="handle-a-dependabot-pull-request"><a class="header" href="#handle-a-dependabot-pull-request">...handle a Dependabot pull request?</a></h2>
|
||||||
<p>Synapse uses Dependabot to keep the <code>poetry.lock</code> file up-to-date. When it
|
<p>Synapse uses Dependabot to keep the <code>poetry.lock</code> and <code>Cargo.lock</code> file
|
||||||
creates a pull request a GitHub Action will run to automatically create a changelog
|
up-to-date with the latest releases of our dependencies. The changelog check is
|
||||||
file. Ensure that:</p>
|
omitted for Dependabot PRs; the release script will include them in the
|
||||||
|
changelog.</p>
|
||||||
|
<p>When reviewing a dependabot PR, ensure that:</p>
|
||||||
<ul>
|
<ul>
|
||||||
<li>the lockfile changes look reasonable;</li>
|
<li>the lockfile changes look reasonable;</li>
|
||||||
<li>the upstream changelog file (linked in the description) doesn't include any
|
<li>the upstream changelog file (linked in the description) doesn't include any
|
||||||
breaking changes;</li>
|
breaking changes;</li>
|
||||||
<li>continuous integration passes (due to permissions, the GitHub Actions run on
|
<li>continuous integration passes.</li>
|
||||||
the changelog commit will fail, look at the initial commit of the pull request);</li>
|
|
||||||
</ul>
|
</ul>
|
||||||
<p>In particular, any updates to the type hints (usually packages which start with <code>types-</code>)
|
<p>In particular, any updates to the type hints (usually packages which start with <code>types-</code>)
|
||||||
should be safe to merge if linting passes.</p>
|
should be safe to merge if linting passes.</p>
|
||||||
|
|
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
Loading…
Reference in a new issue