Matrix/synapse
Matrix/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse synced 2024-08-20 05:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Log when we get an invalid body on certain CS-API requests

Browse source 
Some endpoints currently accept an invalid JSON object in the request body,
which we should stop. As a starting point, let's log when it happens so that we
can fix it.
This commit is contained in:
Richard van der Hoff 2022-07-26 11:14:05 +01:00
parent c7c84b81e3
commit dd59f1ecbf
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/13386.misc Normal file
View file

@ -0,0 +1 @@
Log when we get an invalid request body on room membership requests.

6
synapse/rest/client/room.py
View file

@ -319,9 +319,10 @@ class JoinRoomAliasServlet(ResolveRoomIdMixin, TransactionRestServlet):
try:
content = parse_json_object_from_request(request)
except Exception:
except Exception as e:
# Turns out we used to ignore the body entirely, and some clients
# cheekily send invalid bodies.
logger.warning("Ignoring invalid body on POST %s: %s", request.path, e)
content = {}
# twisted.web.server.Request.args is incorrectly defined as Optional[Any]
@ -855,9 +856,10 @@ class RoomMembershipRestServlet(TransactionRestServlet):
try:
content = parse_json_object_from_request(request)
except Exception:
except Exception as e:
# Turns out we used to ignore the body entirely, and some clients
# cheekily send invalid bodies.
logger.warning("Ignoring invalid body on POST %s: %s", request.path, e)
content = {}
if membership_action == "invite" and self._has_3pid_invite_keys(content):