mirror of
https://github.com/element-hq/synapse
synced 2024-07-08 15:14:08 +00:00
f85b6ca494
Instead of calculating the size of the cache repeatedly, which can take a long time now that it can use a callback, instead cache the size and update that on insertion and deletion. This requires changing the cache descriptors to have two caches, one for pending deferreds and the other for the actual values. There's no reason to evict from the pending deferreds as they won't take up any more memory.
320 lines
7.8 KiB
Python
320 lines
7.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2015, 2016 OpenMarket Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
|
|
from tests import unittest
|
|
from twisted.internet import defer
|
|
|
|
from mock import Mock
|
|
|
|
from synapse.util.async import ObservableDeferred
|
|
|
|
from synapse.util.caches.descriptors import Cache, cached
|
|
|
|
|
|
class CacheTestCase(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
self.cache = Cache("test")
|
|
|
|
def test_empty(self):
|
|
failed = False
|
|
try:
|
|
self.cache.get("foo")
|
|
except KeyError:
|
|
failed = True
|
|
|
|
self.assertTrue(failed)
|
|
|
|
def test_hit(self):
|
|
self.cache.prefill("foo", 123)
|
|
|
|
self.assertEquals(self.cache.get("foo"), 123)
|
|
|
|
def test_invalidate(self):
|
|
self.cache.prefill(("foo",), 123)
|
|
self.cache.invalidate(("foo",))
|
|
|
|
failed = False
|
|
try:
|
|
self.cache.get(("foo",))
|
|
except KeyError:
|
|
failed = True
|
|
|
|
self.assertTrue(failed)
|
|
|
|
def test_eviction(self):
|
|
cache = Cache("test", max_entries=2)
|
|
|
|
cache.prefill(1, "one")
|
|
cache.prefill(2, "two")
|
|
cache.prefill(3, "three") # 1 will be evicted
|
|
|
|
failed = False
|
|
try:
|
|
cache.get(1)
|
|
except KeyError:
|
|
failed = True
|
|
|
|
self.assertTrue(failed)
|
|
|
|
cache.get(2)
|
|
cache.get(3)
|
|
|
|
def test_eviction_lru(self):
|
|
cache = Cache("test", max_entries=2)
|
|
|
|
cache.prefill(1, "one")
|
|
cache.prefill(2, "two")
|
|
|
|
# Now access 1 again, thus causing 2 to be least-recently used
|
|
cache.get(1)
|
|
|
|
cache.prefill(3, "three")
|
|
|
|
failed = False
|
|
try:
|
|
cache.get(2)
|
|
except KeyError:
|
|
failed = True
|
|
|
|
self.assertTrue(failed)
|
|
|
|
cache.get(1)
|
|
cache.get(3)
|
|
|
|
|
|
class CacheDecoratorTestCase(unittest.TestCase):
|
|
|
|
@defer.inlineCallbacks
|
|
def test_passthrough(self):
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
return key
|
|
|
|
a = A()
|
|
|
|
self.assertEquals((yield a.func("foo")), "foo")
|
|
self.assertEquals((yield a.func("bar")), "bar")
|
|
|
|
@defer.inlineCallbacks
|
|
def test_hit(self):
|
|
callcount = [0]
|
|
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
a = A()
|
|
yield a.func("foo")
|
|
|
|
self.assertEquals(callcount[0], 1)
|
|
|
|
self.assertEquals((yield a.func("foo")), "foo")
|
|
self.assertEquals(callcount[0], 1)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_invalidate(self):
|
|
callcount = [0]
|
|
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
a = A()
|
|
yield a.func("foo")
|
|
|
|
self.assertEquals(callcount[0], 1)
|
|
|
|
a.func.invalidate(("foo",))
|
|
|
|
yield a.func("foo")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
|
|
def test_invalidate_missing(self):
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
return key
|
|
|
|
A().func.invalidate(("what",))
|
|
|
|
@defer.inlineCallbacks
|
|
def test_max_entries(self):
|
|
callcount = [0]
|
|
|
|
class A(object):
|
|
@cached(max_entries=10)
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
a = A()
|
|
|
|
for k in range(0, 12):
|
|
yield a.func(k)
|
|
|
|
self.assertEquals(callcount[0], 12)
|
|
|
|
# There must have been at least 2 evictions, meaning if we calculate
|
|
# all 12 values again, we must get called at least 2 more times
|
|
for k in range(0, 12):
|
|
yield a.func(k)
|
|
|
|
self.assertTrue(
|
|
callcount[0] >= 14,
|
|
msg="Expected callcount >= 14, got %d" % (callcount[0])
|
|
)
|
|
|
|
def test_prefill(self):
|
|
callcount = [0]
|
|
|
|
d = defer.succeed(123)
|
|
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return d
|
|
|
|
a = A()
|
|
|
|
a.func.prefill(("foo",), ObservableDeferred(d))
|
|
|
|
self.assertEquals(a.func("foo").result, d.result)
|
|
self.assertEquals(callcount[0], 0)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_invalidate_context(self):
|
|
callcount = [0]
|
|
callcount2 = [0]
|
|
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
@cached(cache_context=True)
|
|
def func2(self, key, cache_context):
|
|
callcount2[0] += 1
|
|
return self.func(key, on_invalidate=cache_context.invalidate)
|
|
|
|
a = A()
|
|
yield a.func2("foo")
|
|
|
|
self.assertEquals(callcount[0], 1)
|
|
self.assertEquals(callcount2[0], 1)
|
|
|
|
a.func.invalidate(("foo",))
|
|
yield a.func("foo")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 1)
|
|
|
|
yield a.func2("foo")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_eviction_context(self):
|
|
callcount = [0]
|
|
callcount2 = [0]
|
|
|
|
class A(object):
|
|
@cached(max_entries=20) # HACK: This makes it 2 due to cache factor
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
@cached(cache_context=True)
|
|
def func2(self, key, cache_context):
|
|
callcount2[0] += 1
|
|
return self.func(key, on_invalidate=cache_context.invalidate)
|
|
|
|
a = A()
|
|
yield a.func2("foo")
|
|
yield a.func2("foo2")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
yield a.func2("foo")
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
yield a.func("foo3")
|
|
|
|
self.assertEquals(callcount[0], 3)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
yield a.func2("foo")
|
|
|
|
self.assertEquals(callcount[0], 4)
|
|
self.assertEquals(callcount2[0], 3)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_double_get(self):
|
|
callcount = [0]
|
|
callcount2 = [0]
|
|
|
|
class A(object):
|
|
@cached()
|
|
def func(self, key):
|
|
callcount[0] += 1
|
|
return key
|
|
|
|
@cached(cache_context=True)
|
|
def func2(self, key, cache_context):
|
|
callcount2[0] += 1
|
|
return self.func(key, on_invalidate=cache_context.invalidate)
|
|
|
|
a = A()
|
|
a.func2.cache.cache = Mock(wraps=a.func2.cache.cache)
|
|
|
|
yield a.func2("foo")
|
|
|
|
self.assertEquals(callcount[0], 1)
|
|
self.assertEquals(callcount2[0], 1)
|
|
|
|
a.func2.invalidate(("foo",))
|
|
self.assertEquals(a.func2.cache.cache.pop.call_count, 1)
|
|
|
|
yield a.func2("foo")
|
|
a.func2.invalidate(("foo",))
|
|
self.assertEquals(a.func2.cache.cache.pop.call_count, 2)
|
|
|
|
self.assertEquals(callcount[0], 1)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
a.func.invalidate(("foo",))
|
|
self.assertEquals(a.func2.cache.cache.pop.call_count, 3)
|
|
yield a.func("foo")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 2)
|
|
|
|
yield a.func2("foo")
|
|
|
|
self.assertEquals(callcount[0], 2)
|
|
self.assertEquals(callcount2[0], 3)
|