mirror of
https://github.com/element-hq/synapse
synced 2024-08-20 12:00:21 +00:00
Turns out that the library does a better job of parsing URIs than our reinvented wheel. Who knew. There are two things going on here. The first is that, unlike parse_server_name, URI.fromBytes will strip off square brackets from IPv6 literals, which means that it is valid input to ClientTLSOptionsFactory and HostnameEndpoint. The second is that we stay in `bytes` throughout (except for the argument to ClientTLSOptionsFactory), which avoids the weirdness of (sometimes) ending up with idna-encoded values being held in `unicode` variables. TBH it probably would have been ok but it made the tests fragile.
1 line
60 B
Text
1 line
60 B
Text
Fix idna and ipv6 literal handling in MatrixFederationAgent
|