From 32b53ea9361a6d30281275a60e98eb1cfe5e640b Mon Sep 17 00:00:00 2001 From: Ryan Foster Date: Tue, 18 Jun 2024 20:11:27 -0400 Subject: [PATCH] CI: Fix Windows Patches action release notes generation By not specifying a checkout ref, actions/checkout does a second checkout when this action is invoked by the Publish workflow (release event). When this happens, it checks out the commit object from the tag, and git can no longer locate the annotated tag that contains the release notes. This then causes the release notes to be just the commit message and not the annotated tag message. The sparkle-appcast action in general and this actioo when invoked via the Dispatch workflow do not have this issue, and they both specify the tag as the ref. --- .github/actions/windows-patches/action.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/windows-patches/action.yaml b/.github/actions/windows-patches/action.yaml index 76a4a3cfd..f4ce585f2 100644 --- a/.github/actions/windows-patches/action.yaml +++ b/.github/actions/windows-patches/action.yaml @@ -25,6 +25,7 @@ runs: with: path: "repo" fetch-depth: 0 + ref: ${{ inputs.tagName }} - name: Download Release Artifact shell: pwsh