OBS/obs-studio
OBS/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-07-19 17:49:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: Don't std::move main in SetUndoProperties

Browse source 
main is used later in the function, making this undefined behavior.
Though we can move the scene_name string.

Detected by PVS Studio.
This commit is contained in:
Richard Stanway 2023-04-02 19:34:50 +02:00 committed by Rodney
parent 288dfd2660
commit a781f4a887
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
UI/context-bar-controls.cpp
View file

@ -56,8 +56,8 @@ void SourceToolbar::SetUndoProperties(obs_source_t *source, bool repeatable)
if (!currentSceneSource)
return;
std::string scene_name = obs_source_get_name(currentSceneSource);
auto undo_redo = [scene_name,
main = std::move(main)](const std::string &data) {
auto undo_redo = [scene_name = std::move(scene_name),
main](const std::string &data) {
OBSDataAutoRelease settings =
obs_data_create_from_json(data.c_str());
OBSSourceAutoRelease source = obs_get_source_by_name(