From 039f54d759e38fafb952823e3a951ea1113358d9 Mon Sep 17 00:00:00 2001 From: prgmitchell <86465454+prgmitchell@users.noreply.github.com> Date: Mon, 24 Jun 2024 01:19:12 -0400 Subject: [PATCH] UI: Log streaming service recommended maximums Log the maximum recommended audio and video bitrate when the user ticks the "Ignore streaming service setting recommendations" box. --- UI/window-basic-main-outputs.cpp | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/UI/window-basic-main-outputs.cpp b/UI/window-basic-main-outputs.cpp index 3473ac2fd..886329229 100644 --- a/UI/window-basic-main-outputs.cpp +++ b/UI/window-basic-main-outputs.cpp @@ -850,7 +850,19 @@ void SimpleOutput::Update() audioSettings); if (!enforceBitrate) { - blog(LOG_INFO, "User is ignoring service bitrate limits."); + int MaxVBitrate, MaxABitrate; + obs_service_get_max_bitrate(main->GetService(), &MaxVBitrate, + &MaxABitrate); + + std::string videoBitrateStr = + MaxVBitrate > 0 ? std::to_string(MaxVBitrate) : "None"; + std::string audioBitrateStr = + MaxABitrate > 0 ? std::to_string(MaxABitrate) : "None"; + + blog(LOG_INFO, + "User is ignoring service bitrate limits.\nService Recommendations:\n\tvideo bitrate: %s\n\taudio bitrate: %s", + videoBitrateStr.c_str(), audioBitrateStr.c_str()); + obs_data_set_int(videoSettings, "bitrate", videoBitrate); obs_data_set_int(audioSettings, "bitrate", audioBitrate); } @@ -1818,8 +1830,20 @@ void AdvancedOutput::UpdateStreamSettings() obs_service_apply_encoder_settings(main->GetService(), settings, nullptr); if (!enforceBitrate) { + int MaxVBitrate, MaxABitrate; + obs_service_get_max_bitrate(main->GetService(), + &MaxVBitrate, &MaxABitrate); + + std::string videoBitrateStr = + MaxVBitrate > 0 ? std::to_string(MaxVBitrate) + : "None"; + std::string audioBitrateStr = + MaxABitrate > 0 ? std::to_string(MaxABitrate) + : "None"; + blog(LOG_INFO, - "User is ignoring service bitrate limits."); + "User is ignoring service bitrate limits.\nService Recommendations:\n\tvideo bitrate: %s\n\taudio bitrate: %s", + videoBitrateStr.c_str(), audioBitrateStr.c_str()); obs_data_set_int(settings, "bitrate", bitrate); }