OBS/obs-studio
OBS/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2024-07-20 01:59:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

obs-qsv11: Avoid overwriting encoding parameters

Browse source 
The query being done will ovewrite ALL invalid parameters. This results
in invalid parameters that are not LowPower settings being overwritten
with 0 either introducing different errors or possibly different
behavior.
This commit is contained in:
Kurt Kartaltepe 2022-12-08 16:34:42 -08:00 committed by Ryan Foster
parent 8d33da1fab
commit f473f45e03
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plugins/obs-qsv11/QSV_Encoder_Internal.cpp
View file

@ -433,7 +433,12 @@ mfxStatus QSV_Encoder_Internal::InitParams(qsv_param_t *pParams,
m_mfxEncParams.ExtParam = extendedBuffers.data();
m_mfxEncParams.NumExtParam = (mfxU16)extendedBuffers.size();
mfxStatus sts = m_pmfxENC->Query(&m_mfxEncParams, &m_mfxEncParams);
// We don't check what was valid or invalid here, just try changing LowPower.
// Ensure set values are not overwritten so in case it wasn't lowPower we fail
// during the parameter check.
mfxVideoParam validParams = {0};
memcpy(&validParams, &m_mfxEncParams, sizeof(validParams));
mfxStatus sts = m_pmfxENC->Query(&m_mfxEncParams, &validParams);
if (sts == MFX_ERR_UNSUPPORTED || sts == MFX_ERR_UNDEFINED_BEHAVIOR) {
if (m_mfxEncParams.mfx.LowPower == MFX_CODINGOPTION_ON) {
m_mfxEncParams.mfx.LowPower = MFX_CODINGOPTION_OFF;