Update pihole-FTL.service
Make this script a bourne shell script, which requires the removal of only a single bashism, the "{n..m}" expansion. Furthermore, since POSIX echo has no reliable command line options, switch to printf when line breaks shall be omitted. On most distros/setups "sh" calls a much lighter bourne shell like dash, which inits and runs much faster than bash.
Remove unused PIDFILE variable, remove the single case of FTLUSER call and remove it as well. Using variables here might give the wrong impression that there is a change these can be varied. But both are hardcoded in many places throughout Pi-hole, so in this service script.
Consolidate and merge the commands to pre-create and set permissions for required files and directories. The /var/log/pihole directory is and was never used, the touch, chmod and chown call can be merged into one each to reduce overhead. Use "-f" option to to fail on missing database files instead of redirecting STDERR, which is otherwise helpful to debug other possible errors, like missing or corrupted commands, filesystem errors and such.
Do not use "which pihole-FTL" when setting capabilities when the hardcoded path /usr/bin/pihole-FTL is used for the actual daemon call. It makes sense to use the full path here, as the Pi-hole installer and updater installs it explicitly there, and so we prevent users from e.g. overriding it via /usr/local/bin/pihole-FTL too easily.
On pgrep and pkill calls, add the "-x" flag to assure that only "pihole-FTL" is matched and not "foo-pihole-FTL" or "pihole-FTL-bar".
Do not remove possible leftovers from previous pihole-FTL processes on start, but on stop instead. Since "start" includes a proceeding "stop" as well, on service start nothing changes, but on service stop, some resources are now freed.
Remove leading "$" from usage message. In bash this was omitted, as $'...' is a special syntax for escape sequence expansion, which is not applicable here. In dash it would be printed literally. To keep previous behaviour, it is hence removed.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-23 18:43:13 +00:00
|
|
|
#!/usr/bin/env sh
|
2017-02-21 10:18:47 +00:00
|
|
|
### BEGIN INIT INFO
|
|
|
|
# Provides: pihole-FTL
|
2020-04-03 17:05:59 +00:00
|
|
|
# Required-Start: $remote_fs $syslog $network
|
|
|
|
# Required-Stop: $remote_fs $syslog $network
|
2017-02-21 10:18:47 +00:00
|
|
|
# Default-Start: 2 3 4 5
|
|
|
|
# Default-Stop: 0 1 6
|
|
|
|
# Short-Description: pihole-FTL daemon
|
|
|
|
# Description: Enable service provided by pihole-FTL daemon
|
|
|
|
### END INIT INFO
|
|
|
|
|
2022-09-18 19:44:06 +00:00
|
|
|
# Source utils.sh for getFTLPIDFile(), getFTLPID()
|
2022-07-26 12:38:03 +00:00
|
|
|
PI_HOLE_SCRIPT_DIR="/opt/pihole"
|
|
|
|
utilsfile="${PI_HOLE_SCRIPT_DIR}/utils.sh"
|
2022-09-18 19:44:06 +00:00
|
|
|
# shellcheck disable=SC1090
|
2022-07-26 12:38:03 +00:00
|
|
|
. "${utilsfile}"
|
2022-05-11 23:03:44 +00:00
|
|
|
|
|
|
|
|
2017-02-21 10:18:47 +00:00
|
|
|
is_running() {
|
2022-05-11 23:03:44 +00:00
|
|
|
if [ -d "/proc/${FTL_PID}" ]; then
|
|
|
|
return 0
|
|
|
|
fi
|
|
|
|
return 1
|
2017-02-21 10:18:47 +00:00
|
|
|
}
|
|
|
|
|
2022-12-08 08:49:02 +00:00
|
|
|
cleanup() {
|
|
|
|
# Run post-stop script, which does cleanup among runtime files
|
|
|
|
sh "${PI_HOLE_SCRIPT_DIR}/pihole-FTL-poststop.sh"
|
|
|
|
}
|
|
|
|
|
2018-02-25 09:11:11 +00:00
|
|
|
|
2017-02-21 10:18:47 +00:00
|
|
|
# Start the service
|
|
|
|
start() {
|
|
|
|
if is_running; then
|
|
|
|
echo "pihole-FTL is already running"
|
|
|
|
else
|
2022-09-18 19:44:06 +00:00
|
|
|
# Run pre-start script, which pre-creates all expected files with correct permissions
|
|
|
|
sh "${PI_HOLE_SCRIPT_DIR}/pihole-FTL-prestart.sh"
|
2022-05-15 20:10:40 +00:00
|
|
|
|
2021-09-11 20:35:11 +00:00
|
|
|
if setcap CAP_NET_BIND_SERVICE,CAP_NET_RAW,CAP_NET_ADMIN,CAP_SYS_NICE,CAP_IPC_LOCK,CAP_CHOWN+eip "/usr/bin/pihole-FTL"; then
|
2022-12-08 08:49:02 +00:00
|
|
|
su -s /bin/sh -c "/usr/bin/pihole-FTL" pihole || ec=$?
|
2018-08-19 12:32:19 +00:00
|
|
|
else
|
|
|
|
echo "Warning: Starting pihole-FTL as root because setting capabilities is not supported on this system"
|
2022-12-08 08:49:02 +00:00
|
|
|
/usr/bin/pihole-FTL || ec=$?
|
|
|
|
fi
|
|
|
|
# Cleanup if startup failed
|
|
|
|
if [ -n "${ec}" ] && [ "${ec}" != 0 ]; then
|
|
|
|
cleanup
|
|
|
|
exit $ec
|
2018-08-19 12:32:19 +00:00
|
|
|
fi
|
2017-02-21 10:18:47 +00:00
|
|
|
echo
|
|
|
|
fi
|
|
|
|
}
|
|
|
|
|
|
|
|
# Stop the service
|
|
|
|
stop() {
|
|
|
|
if is_running; then
|
2022-05-11 23:03:44 +00:00
|
|
|
kill "${FTL_PID}"
|
Update pihole-FTL.service
Make this script a bourne shell script, which requires the removal of only a single bashism, the "{n..m}" expansion. Furthermore, since POSIX echo has no reliable command line options, switch to printf when line breaks shall be omitted. On most distros/setups "sh" calls a much lighter bourne shell like dash, which inits and runs much faster than bash.
Remove unused PIDFILE variable, remove the single case of FTLUSER call and remove it as well. Using variables here might give the wrong impression that there is a change these can be varied. But both are hardcoded in many places throughout Pi-hole, so in this service script.
Consolidate and merge the commands to pre-create and set permissions for required files and directories. The /var/log/pihole directory is and was never used, the touch, chmod and chown call can be merged into one each to reduce overhead. Use "-f" option to to fail on missing database files instead of redirecting STDERR, which is otherwise helpful to debug other possible errors, like missing or corrupted commands, filesystem errors and such.
Do not use "which pihole-FTL" when setting capabilities when the hardcoded path /usr/bin/pihole-FTL is used for the actual daemon call. It makes sense to use the full path here, as the Pi-hole installer and updater installs it explicitly there, and so we prevent users from e.g. overriding it via /usr/local/bin/pihole-FTL too easily.
On pgrep and pkill calls, add the "-x" flag to assure that only "pihole-FTL" is matched and not "foo-pihole-FTL" or "pihole-FTL-bar".
Do not remove possible leftovers from previous pihole-FTL processes on start, but on stop instead. Since "start" includes a proceeding "stop" as well, on service start nothing changes, but on service stop, some resources are now freed.
Remove leading "$" from usage message. In bash this was omitted, as $'...' is a special syntax for escape sequence expansion, which is not applicable here. In dash it would be printed literally. To keep previous behaviour, it is hence removed.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-23 18:43:13 +00:00
|
|
|
for i in 1 2 3 4 5; do
|
2017-02-21 10:18:47 +00:00
|
|
|
if ! is_running; then
|
|
|
|
break
|
|
|
|
fi
|
|
|
|
|
Update pihole-FTL.service
Make this script a bourne shell script, which requires the removal of only a single bashism, the "{n..m}" expansion. Furthermore, since POSIX echo has no reliable command line options, switch to printf when line breaks shall be omitted. On most distros/setups "sh" calls a much lighter bourne shell like dash, which inits and runs much faster than bash.
Remove unused PIDFILE variable, remove the single case of FTLUSER call and remove it as well. Using variables here might give the wrong impression that there is a change these can be varied. But both are hardcoded in many places throughout Pi-hole, so in this service script.
Consolidate and merge the commands to pre-create and set permissions for required files and directories. The /var/log/pihole directory is and was never used, the touch, chmod and chown call can be merged into one each to reduce overhead. Use "-f" option to to fail on missing database files instead of redirecting STDERR, which is otherwise helpful to debug other possible errors, like missing or corrupted commands, filesystem errors and such.
Do not use "which pihole-FTL" when setting capabilities when the hardcoded path /usr/bin/pihole-FTL is used for the actual daemon call. It makes sense to use the full path here, as the Pi-hole installer and updater installs it explicitly there, and so we prevent users from e.g. overriding it via /usr/local/bin/pihole-FTL too easily.
On pgrep and pkill calls, add the "-x" flag to assure that only "pihole-FTL" is matched and not "foo-pihole-FTL" or "pihole-FTL-bar".
Do not remove possible leftovers from previous pihole-FTL processes on start, but on stop instead. Since "start" includes a proceeding "stop" as well, on service start nothing changes, but on service stop, some resources are now freed.
Remove leading "$" from usage message. In bash this was omitted, as $'...' is a special syntax for escape sequence expansion, which is not applicable here. In dash it would be printed literally. To keep previous behaviour, it is hence removed.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-23 18:43:13 +00:00
|
|
|
printf "."
|
2017-02-21 10:18:47 +00:00
|
|
|
sleep 1
|
|
|
|
done
|
|
|
|
echo
|
|
|
|
|
|
|
|
if is_running; then
|
2017-04-12 21:13:18 +00:00
|
|
|
echo "Not stopped; may still be shutting down or shutdown may have failed, killing now"
|
2022-05-11 23:03:44 +00:00
|
|
|
kill -9 "${FTL_PID}"
|
2017-02-21 10:18:47 +00:00
|
|
|
else
|
|
|
|
echo "Stopped"
|
|
|
|
fi
|
|
|
|
else
|
|
|
|
echo "Not running"
|
|
|
|
fi
|
2022-12-08 08:49:02 +00:00
|
|
|
cleanup
|
2017-02-21 10:18:47 +00:00
|
|
|
echo
|
|
|
|
}
|
|
|
|
|
2018-06-02 05:30:51 +00:00
|
|
|
# Indicate the service status
|
|
|
|
status() {
|
|
|
|
if is_running; then
|
|
|
|
echo "[ ok ] pihole-FTL is running"
|
|
|
|
exit 0
|
|
|
|
else
|
|
|
|
echo "[ ] pihole-FTL is not running"
|
|
|
|
exit 1
|
|
|
|
fi
|
2018-08-19 11:53:34 +00:00
|
|
|
}
|
2018-06-02 05:30:51 +00:00
|
|
|
|
|
|
|
|
2017-02-21 10:18:47 +00:00
|
|
|
### main logic ###
|
2022-05-11 23:03:44 +00:00
|
|
|
|
2022-12-08 08:49:02 +00:00
|
|
|
# catch sudden termination
|
|
|
|
trap 'cleanup; exit 1' INT HUP TERM ABRT
|
|
|
|
|
2022-09-18 19:44:06 +00:00
|
|
|
# Get FTL's PID file path
|
2022-07-26 12:38:03 +00:00
|
|
|
FTL_PID_FILE="$(getFTLPIDFile)"
|
2022-05-11 23:03:44 +00:00
|
|
|
|
|
|
|
# Get FTL's current PID
|
2022-09-18 19:44:06 +00:00
|
|
|
FTL_PID="$(getFTLPID "${FTL_PID_FILE}")"
|
2022-05-11 23:03:44 +00:00
|
|
|
|
2017-02-21 10:18:47 +00:00
|
|
|
case "$1" in
|
|
|
|
stop)
|
|
|
|
stop
|
|
|
|
;;
|
|
|
|
status)
|
2018-06-02 05:30:51 +00:00
|
|
|
status
|
2017-02-21 10:18:47 +00:00
|
|
|
;;
|
2017-04-12 21:13:18 +00:00
|
|
|
start|restart|reload|condrestart)
|
2017-02-21 10:18:47 +00:00
|
|
|
stop
|
|
|
|
start
|
|
|
|
;;
|
|
|
|
*)
|
Update pihole-FTL.service
Make this script a bourne shell script, which requires the removal of only a single bashism, the "{n..m}" expansion. Furthermore, since POSIX echo has no reliable command line options, switch to printf when line breaks shall be omitted. On most distros/setups "sh" calls a much lighter bourne shell like dash, which inits and runs much faster than bash.
Remove unused PIDFILE variable, remove the single case of FTLUSER call and remove it as well. Using variables here might give the wrong impression that there is a change these can be varied. But both are hardcoded in many places throughout Pi-hole, so in this service script.
Consolidate and merge the commands to pre-create and set permissions for required files and directories. The /var/log/pihole directory is and was never used, the touch, chmod and chown call can be merged into one each to reduce overhead. Use "-f" option to to fail on missing database files instead of redirecting STDERR, which is otherwise helpful to debug other possible errors, like missing or corrupted commands, filesystem errors and such.
Do not use "which pihole-FTL" when setting capabilities when the hardcoded path /usr/bin/pihole-FTL is used for the actual daemon call. It makes sense to use the full path here, as the Pi-hole installer and updater installs it explicitly there, and so we prevent users from e.g. overriding it via /usr/local/bin/pihole-FTL too easily.
On pgrep and pkill calls, add the "-x" flag to assure that only "pihole-FTL" is matched and not "foo-pihole-FTL" or "pihole-FTL-bar".
Do not remove possible leftovers from previous pihole-FTL processes on start, but on stop instead. Since "start" includes a proceeding "stop" as well, on service start nothing changes, but on service stop, some resources are now freed.
Remove leading "$" from usage message. In bash this was omitted, as $'...' is a special syntax for escape sequence expansion, which is not applicable here. In dash it would be printed literally. To keep previous behaviour, it is hence removed.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-23 18:43:13 +00:00
|
|
|
echo "Usage: $0 {start|stop|restart|reload|status}"
|
2017-02-21 10:18:47 +00:00
|
|
|
exit 1
|
|
|
|
esac
|
|
|
|
|
|
|
|
exit 0
|