Review comments and fixing stickler complaints.

Signed-off-by: DL6ER <dl6er@dl6er.de>
This commit is contained in:
DL6ER 2019-07-06 09:32:41 +02:00
parent 2fb4256f84
commit 0405aaa3da
No known key found for this signature in database
GPG key ID: 00135ACBD90B28DD
5 changed files with 34 additions and 17 deletions

View file

@ -11,11 +11,11 @@
# Please see LICENSE file for your rights under this license.
upgrade_gravityDB(){
local version=$(sqlite3 "$1" "SELECT "value" FROM "info" WHERE "property" = 'version';")
local version
version=$(sqlite3 "$1" "SELECT "value" FROM "info" WHERE "property" = 'version';")
case "$version" in
1)
if [[ "$version" == "1" ]]; then
sqlite3 "$1" < "/etc/.pihole/advanced/Scripts/database_migration/gravity/1_to_2.sql"
;;
esac
version=2
fi
}

View file

@ -1,4 +1,4 @@
CREATE TABLE auditlist
CREATE TABLE domain_auditlist
(
id INTEGER PRIMARY KEY AUTOINCREMENT,
domain TEXT UNIQUE NOT NULL,

View file

@ -542,24 +542,38 @@ Teleporter() {
php /var/www/html/admin/scripts/pi-hole/php/teleporter.php > "pi-hole-teleporter_${datetimestamp}.tar.gz"
}
checkDomain()
{
local domain validDomain
# Convert to lowercase
domain="${1,,}"
validDomain=$(grep -P "^((-|_)*[a-z\\d]((-|_)*[a-z\\d])*(-|_)*)(\\.(-|_)*([a-z\\d]((-|_)*[a-z\\d])*))*$" <<< "${domain}") # Valid chars check
validDomain=$(grep -P "^[^\\.]{1,63}(\\.[^\\.]{1,63})*$" <<< "${validDomain}") # Length of each label
echo "${validDomain}"
}
addAudit()
{
shift # skip "-a"
shift # skip "audit"
local domains="('${1}')"
local domains validDomain
domains="('$(checkDomain "${1}")')"
shift # skip first domain, as it has already been added
for domain in "$@"
do
# Insert only the domain here. The date_added field will be
# filled with its default value (date_added = current timestamp)
domains="${domains},('${domain}')"
validDomain="$(checkDomain "${domain}")"
if [[ -n "${validDomain}" ]]; then
domains="${domains},('${domain}')"
fi
done
sqlite3 "${gravityDBfile}" "INSERT INTO \"auditlist\" (domain) VALUES ${domains};"
sqlite3 "${gravityDBfile}" "INSERT INTO \"domain_auditlist\" (domain) VALUES ${domains};"
}
clearAudit()
{
sqlite3 "${gravityDBfile}" "DELETE FROM \"auditlist\";"
sqlite3 "${gravityDBfile}" "DELETE FROM \"domain_auditlist\";"
}
SetPrivacyLevel() {