mirror of
https://github.com/pi-hole/pi-hole.git
synced 2025-04-01 05:00:24 +00:00
consistency
Just more cleanup
This commit is contained in:
parent
ec4f5007e7
commit
0f04e270a7
1 changed files with 95 additions and 99 deletions
|
@ -47,119 +47,117 @@ domToRemoveList=()
|
||||||
piholeIPfile=/etc/pihole/piholeIP
|
piholeIPfile=/etc/pihole/piholeIP
|
||||||
piholeIPv6file=/etc/pihole/.useIPv6
|
piholeIPv6file=/etc/pihole/.useIPv6
|
||||||
|
|
||||||
if [[ -f ${piholeIPfile} ]];then
|
if [[ -f ${piholeIPfile} ]]; then
|
||||||
# If the file exists, it means it was exported from the installation script and we should use that value instead of detecting it in this script
|
# If the file exists, it means it was exported from the installation script and we should use that value instead of detecting it in this script
|
||||||
piholeIP=$(cat ${piholeIPfile})
|
piholeIP=$(cat ${piholeIPfile})
|
||||||
#rm $piholeIPfile
|
#rm $piholeIPfile
|
||||||
else
|
else
|
||||||
# Otherwise, the IP address can be taken directly from the machine, which will happen when the script is run by the user and not the installation script
|
# Otherwise, the IP address can be taken directly from the machine, which will happen when the script is run by the user and not the installation script
|
||||||
IPv4dev=$(ip route get 8.8.8.8 | awk '{for(i=1;i<=NF;i++)if($i~/dev/)print $(i+1)}')
|
IPv4dev=$(ip route get 8.8.8.8 | awk '{for(i=1;i<=NF;i++)if($i~/dev/)print $(i+1)}')
|
||||||
piholeIPCIDR=$(ip -o -f inet addr show dev "$IPv4dev" | awk '{print $4}' | awk 'END {print}')
|
piholeIPCIDR=$(ip -o -f inet addr show dev "$IPv4dev" | awk '{print $4}' | awk 'END {print}')
|
||||||
piholeIP=${piholeIPCIDR%/*}
|
piholeIP=${piholeIPCIDR%/*}
|
||||||
fi
|
fi
|
||||||
|
|
||||||
modifyHost=false
|
modifyHost=false
|
||||||
|
|
||||||
# After setting defaults, check if there's local overrides
|
# After setting defaults, check if there's local overrides
|
||||||
if [[ -r ${piholeDir}/pihole.conf ]];then
|
if [[ -r ${piholeDir}/pihole.conf ]]; then
|
||||||
echo "::: Local calibration requested..."
|
echo "::: Local calibration requested..."
|
||||||
. ${piholeDir}/pihole.conf
|
. ${piholeDir}/pihole.conf
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
|
||||||
if [[ -f ${piholeIPv6file} ]];then
|
if [[ -f ${piholeIPv6file} ]]; then
|
||||||
# If the file exists, then the user previously chose to use IPv6 in the automated installer
|
# If the file exists, then the user previously chose to use IPv6 in the automated installer
|
||||||
piholeIPv6=$(ip -6 route get 2001:4860:4860::8888 | awk -F " " '{ for(i=1;i<=NF;i++) if ($i == "src") print $(i+1) }')
|
piholeIPv6=$(ip -6 route get 2001:4860:4860::8888 | awk -F " " '{ for(i=1;i<=NF;i++) if ($i == "src") print $(i+1) }')
|
||||||
fi
|
fi
|
||||||
|
|
||||||
HandleOther() {
|
HandleOther() {
|
||||||
#check validity of domain
|
#check validity of domain
|
||||||
validDomain=$(echo "$1" | perl -ne'print if /\b((?=[a-z0-9-]{1,63}\.)(xn--)?[a-z0-9]+(-[a-z0-9]+)*\.)+[a-z]{2,63}\b/')
|
validDomain=$(echo "${1}" | perl -ne'print if /\b((?=[a-z0-9-]{1,63}\.)(xn--)?[a-z0-9]+(-[a-z0-9]+)*\.)+[a-z]{2,63}\b/')
|
||||||
if [ -z "$validDomain" ]; then
|
if [ -z "${validDomain}" ]; then
|
||||||
echo "::: $1 is not a valid argument or domain name"
|
echo "::: ${1} is not a valid argument or domain name"
|
||||||
else
|
else
|
||||||
domList=("${domList[@]}" ${validDomain})
|
domList=("${domList[@]}" ${validDomain})
|
||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
|
||||||
PopBlacklistFile() {
|
PopBlacklistFile() {
|
||||||
#check blacklist file exists, and if not, create it
|
#check blacklist file exists, and if not, create it
|
||||||
if [[ ! -f ${blacklist} ]];then
|
if [[ ! -f ${blacklist} ]]; then
|
||||||
touch ${blacklist}
|
touch ${blacklist}
|
||||||
fi
|
fi
|
||||||
for dom in "${domList[@]}"; do
|
for dom in "${domList[@]}"; do
|
||||||
if "$addmode"; then
|
if "${addmode}"; then
|
||||||
AddDomain "$dom"
|
AddDomain "${dom}"
|
||||||
else
|
else
|
||||||
RemoveDomain "$dom"
|
RemoveDomain "${dom}"
|
||||||
fi
|
fi
|
||||||
done
|
done
|
||||||
}
|
}
|
||||||
|
|
||||||
AddDomain() {
|
AddDomain() {
|
||||||
#| sed 's/\./\\./g'
|
#| sed 's/\./\\./g'
|
||||||
bool=false
|
bool=false
|
||||||
grep -Ex -q "$1" ${blacklist} || bool=true
|
grep -Ex -q "$1" ${blacklist} || bool=true
|
||||||
if ${bool}; then
|
if ${bool}; then
|
||||||
#domain not found in the blacklist file, add it!
|
#domain not found in the blacklist file, add it!
|
||||||
if ${verbose}; then
|
if ${verbose}; then
|
||||||
echo -n "::: Adding $1 to blacklist file..."
|
echo -n "::: Adding $1 to blacklist file..."
|
||||||
fi
|
fi
|
||||||
echo "$1" >> ${blacklist}
|
echo "${1}" >> ${blacklist}
|
||||||
modifyHost=true
|
modifyHost=true
|
||||||
echo " done!"
|
echo " done!"
|
||||||
else
|
else
|
||||||
if ${verbose}; then
|
if ${verbose}; then
|
||||||
echo "::: $1 already exists in $blacklist! No need to add"
|
echo "::: ${1} already exists in ${blacklist}! No need to add"
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
|
||||||
RemoveDomain() {
|
RemoveDomain() {
|
||||||
|
bool=false
|
||||||
bool=false
|
grep -Ex -q "$1" ${blacklist} || bool=true
|
||||||
grep -Ex -q "$1" ${blacklist} || bool=true
|
if ${bool}; then
|
||||||
if ${bool}; then
|
#Domain is not in the blacklist file, no need to Remove
|
||||||
#Domain is not in the blacklist file, no need to Remove
|
if ${verbose}; then
|
||||||
if ${verbose}; then
|
echo "::: $1 is NOT blacklisted! No need to remove"
|
||||||
echo "::: $1 is NOT blacklisted! No need to remove"
|
fi
|
||||||
fi
|
else
|
||||||
else
|
#Domain is in the blacklist file, add to a temporary array
|
||||||
#Domain is in the blacklist file, add to a temporary array
|
if ${verbose}; then
|
||||||
if ${verbose}; then
|
echo "::: Un-blacklisting ${dom}..."
|
||||||
echo "::: Un-blacklisting $dom..."
|
fi
|
||||||
fi
|
domToRemoveList=("${domToRemoveList[@]}" $1)
|
||||||
domToRemoveList=("${domToRemoveList[@]}" $1)
|
modifyHost=true
|
||||||
modifyHost=true
|
fi
|
||||||
fi
|
|
||||||
}
|
}
|
||||||
|
|
||||||
ModifyHostFile() {
|
ModifyHostFile() {
|
||||||
if ${addmode}; then
|
if ${addmode}; then
|
||||||
#add domains to the hosts file
|
#add domains to the hosts file
|
||||||
if [[ -r ${blacklist} ]];then
|
if [[ -r ${blacklist} ]]; then
|
||||||
numberOf=$(cat ${blacklist} | sed '/^\s*$/d' | wc -l)
|
numberOf=$(cat ${blacklist} | sed '/^\s*$/d' | wc -l)
|
||||||
plural=; [[ "$numberOf" != "1" ]] && plural=s
|
plural=; [[ "${numberOf}" != "1" ]] && plural=s
|
||||||
echo ":::"
|
echo ":::"
|
||||||
echo -n "::: Modifying HOSTS file to blacklist $numberOf domain${plural}..."
|
echo -n "::: Modifying HOSTS file to blacklist $numberOf domain${plural}..."
|
||||||
if [[ -n ${piholeIPv6} ]];then
|
if [[ -n ${piholeIPv6} ]]; then
|
||||||
cat ${blacklist} | awk -v ipv4addr="$piholeIP" -v ipv6addr="$piholeIPv6" '{sub(/\r$/,""); print ipv4addr" "$0"\n"ipv6addr" "$0}' >> ${adList}
|
cat ${blacklist} | awk -v ipv4addr="$piholeIP" -v ipv6addr="$piholeIPv6" '{sub(/\r$/,""); print ipv4addr" "$0"\n"ipv6addr" "$0}' >> ${adList}
|
||||||
else
|
else
|
||||||
cat ${blacklist} | awk -v ipv4addr="$piholeIP" '{sub(/\r$/,""); print ipv4addr" "$0}' >>${adList}
|
cat ${blacklist} | awk -v ipv4addr="$piholeIP" '{sub(/\r$/,""); print ipv4addr" "$0}' >>${adList}
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
else
|
else
|
||||||
echo ":::"
|
echo ":::"
|
||||||
for dom in "${domToRemoveList[@]}"
|
for dom in "${domToRemoveList[@]}"; do
|
||||||
do
|
#we need to remove the domains from the blacklist file and the host file
|
||||||
#we need to remove the domains from the blacklist file and the host file
|
echo "::: ${dom}"
|
||||||
echo "::: $dom"
|
|
||||||
echo -n "::: removing from HOSTS file..."
|
echo -n "::: removing from HOSTS file..."
|
||||||
echo "$dom" | sed 's/\./\\./g' | xargs -I {} perl -i -ne'print unless /[^.]'{}'(?!.)/;' ${adList}
|
echo "${dom}" | sed 's/\./\\./g' | xargs -I {} perl -i -ne'print unless /[^.]'{}'(?!.)/;' ${adList}
|
||||||
echo " done!"
|
echo " done!"
|
||||||
echo -n "::: removing from blackist.txt..."
|
echo -n "::: removing from blackist.txt..."
|
||||||
echo "$dom" | sed 's/\./\\./g' | xargs -I {} perl -i -ne'print unless /'{}'(?!.)/;' ${blacklist}
|
echo "${dom}" | sed 's/\./\\./g' | xargs -I {} perl -i -ne'print unless /'{}'(?!.)/;' ${blacklist}
|
||||||
echo " done!"
|
echo " done!"
|
||||||
done
|
done
|
||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
@ -169,22 +167,22 @@ Reload() {
|
||||||
echo ":::"
|
echo ":::"
|
||||||
echo -n "::: Refresh lists in dnsmasq..."
|
echo -n "::: Refresh lists in dnsmasq..."
|
||||||
|
|
||||||
dnsmasqPid=$(pidof dnsmasq)
|
dnsmasqPid=$(pidof dnsmasq)
|
||||||
|
|
||||||
if [[ ${dnsmasqPid} ]]; then
|
if [[ ${dnsmasqPid} ]]; then
|
||||||
# service already running - reload config
|
# service already running - reload config
|
||||||
if [ -x "$(command -v systemctl)" ]; then
|
if [ -x "$(command -v systemctl)" ]; then
|
||||||
systemctl restart dnsmasq
|
systemctl restart dnsmasq
|
||||||
else
|
else
|
||||||
service dnsmasq restart
|
service dnsmasq restart
|
||||||
fi
|
fi
|
||||||
else
|
else
|
||||||
# service not running, start it up
|
# service not running, start it up
|
||||||
if [ -x "$(command -v systemctl)" ]; then
|
if [ -x "$(command -v systemctl)" ]; then
|
||||||
systemctl start dnsmasq
|
systemctl start dnsmasq
|
||||||
else
|
else
|
||||||
service dnsmasq start
|
service dnsmasq start
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
echo " done!"
|
echo " done!"
|
||||||
}
|
}
|
||||||
|
@ -193,26 +191,24 @@ DisplayBlist() {
|
||||||
verbose=false
|
verbose=false
|
||||||
echo -e " Displaying Gravity Affected Domains \n"
|
echo -e " Displaying Gravity Affected Domains \n"
|
||||||
count=1
|
count=1
|
||||||
while IFS= read -r AD
|
while IFS= read -r AD; do
|
||||||
do
|
echo "${count}: ${AD}"
|
||||||
echo "${count}: $AD"
|
|
||||||
count=$((count+1))
|
count=$((count+1))
|
||||||
done < "$blacklist"
|
done < "${blacklist}"
|
||||||
}
|
}
|
||||||
|
|
||||||
###################################################
|
###################################################
|
||||||
|
|
||||||
for var in "$@"
|
for var in "$@"; do
|
||||||
do
|
case "$var" in
|
||||||
case "$var" in
|
"-nr"| "--noreload" ) reload=false;;
|
||||||
"-nr"| "--noreload" ) reload=false;;
|
"-d" | "--delmode" ) addmode=false;;
|
||||||
"-d" | "--delmode" ) addmode=false;;
|
"-f" | "--force" ) force=true;;
|
||||||
"-f" | "--force" ) force=true;;
|
"-q" | "--quiet" ) verbose=false;;
|
||||||
"-q" | "--quiet" ) verbose=false;;
|
"-h" | "--help" ) helpFunc;;
|
||||||
"-h" | "--help" ) helpFunc;;
|
"-l" | "--list" ) DisplayBlist;;
|
||||||
"-l" | "--list" ) DisplayBlist;;
|
* ) HandleOther "$var";;
|
||||||
* ) HandleOther "$var";;
|
esac
|
||||||
esac
|
|
||||||
done
|
done
|
||||||
|
|
||||||
PopBlacklistFile
|
PopBlacklistFile
|
||||||
|
@ -220,7 +216,7 @@ PopBlacklistFile
|
||||||
if ${modifyHost} || ${force}; then
|
if ${modifyHost} || ${force}; then
|
||||||
ModifyHostFile
|
ModifyHostFile
|
||||||
else
|
else
|
||||||
if ${verbose}; then
|
if ${verbose}; then
|
||||||
echo "::: No changes need to be made"
|
echo "::: No changes need to be made"
|
||||||
fi
|
fi
|
||||||
exit 1
|
exit 1
|
||||||
|
|
Loading…
Add table
Reference in a new issue