diff --git a/advanced/Scripts/list.sh b/advanced/Scripts/list.sh index 8c930f04..5c57f878 100755 --- a/advanced/Scripts/list.sh +++ b/advanced/Scripts/list.sh @@ -192,7 +192,7 @@ GetComment() { comment="$1" if [[ "${comment}" =~ [^a-zA-Z0-9_\#:/\.,\ -] ]]; then echo " ${CROSS} Found invalid characters in domain comment!" - exit + exit 1 fi } diff --git a/advanced/Scripts/update.sh b/advanced/Scripts/update.sh index e4f784ba..72ba294e 100755 --- a/advanced/Scripts/update.sh +++ b/advanced/Scripts/update.sh @@ -38,10 +38,13 @@ GitCheckUpdateAvail() { local curBranch directory="${1}" curdir=$PWD - cd "${directory}" || return + cd "${directory}" || exit 1 # Fetch latest changes in this repo - git fetch --quiet origin + if ! git fetch --quiet origin ; then + echo -e "\\n ${COL_LIGHT_RED}Error: Unable to update local repository. Contact Pi-hole Support.${COL_NC}" + exit 1 + fi # Check current branch. If it is master, then check for the latest available tag instead of latest commit. curBranch=$(git rev-parse --abbrev-ref HEAD) @@ -71,17 +74,17 @@ GitCheckUpdateAvail() { echo -e "\\n ${COL_LIGHT_RED}Error: Local revision could not be obtained, please contact Pi-hole Support" echo -e " Additional debugging output:${COL_NC}" git status - exit + exit 1 fi if [[ "${#REMOTE}" == 0 ]]; then echo -e "\\n ${COL_LIGHT_RED}Error: Remote revision could not be obtained, please contact Pi-hole Support" echo -e " Additional debugging output:${COL_NC}" git status - exit + exit 1 fi # Change back to original directory - cd "${curdir}" || exit + cd "${curdir}" || exit 1 if [[ "${LOCAL}" != "${REMOTE}" ]]; then # Local branch is behind remote branch -> Update diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index 4852929c..18bccab1 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -409,7 +409,7 @@ package_manager_detect() { # we cannot install required packages printf " %b No supported package manager found\\n" "${CROSS}" # so exit the installer - exit + exit 1 fi }