From 51765b1f659a5fe5023bb0c2001ebce4ed8be861 Mon Sep 17 00:00:00 2001
From: Adam Warner <adamw@rner.email>
Date: Fri, 23 Mar 2018 10:15:40 +0000
Subject: [PATCH 1/2] chown pihole log to pihole:pihole, rather than
 pihole:root

Signed-off-by: Adam Warner <adamw@rner.email>
---
 automated install/basic-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh
index a5d52309..c2e44843 100755
--- a/automated install/basic-install.sh	
+++ b/automated install/basic-install.sh	
@@ -1323,7 +1323,7 @@ CreateLogFile() {
     # set the permissions,
     chmod 644 /var/log/pihole.log
     # and owners
-    chown pihole:root /var/log/pihole.log
+    chown pihole:pihole /var/log/pihole.log
     echo -e "${OVER}  ${TICK} ${str}"
   # Otherwise,
   else

From 238a56cac3a0ca958900e4e465ed97b5e326ff77 Mon Sep 17 00:00:00 2001
From: Adam Warner <adamw@rner.email>
Date: Fri, 23 Mar 2018 10:53:22 +0000
Subject: [PATCH 2/2] Remove CreateLogFile function, as this is handled by the
 FTL service

Signed-off-by: Adam Warner <adamw@rner.email>
---
 automated install/basic-install.sh | 27 +--------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)

diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh
index c2e44843..01a1aff0 100755
--- a/automated install/basic-install.sh	
+++ b/automated install/basic-install.sh	
@@ -1311,27 +1311,6 @@ install_dependent_packages() {
   return 0
 }
 
-# Create logfiles if necessary
-CreateLogFile() {
-  local str="Creating log and changing owner to pihole"
-  echo ""
-  echo -ne "  ${INFO} ${str}..."
-  # If the pihole log does not exist,
-  if [[ ! -f "/var/log/pihole.log" ]]; then
-    # Make it,
-    touch /var/log/pihole.log
-    # set the permissions,
-    chmod 644 /var/log/pihole.log
-    # and owners
-    chown pihole:pihole /var/log/pihole.log
-    echo -e "${OVER}  ${TICK} ${str}"
-  # Otherwise,
-  else
-    # the file should already exist
-    echo -e " ${COL_LIGHT_GREEN}log already exists!${COL_NC}"
-  fi
-}
-
 # Install the Web interface dashboard
 installPiholeWeb() {
   echo ""
@@ -1577,8 +1556,6 @@ installPihole() {
   installScripts
   # configs,
   installConfigs
-  # and create the log file
-  CreateLogFile
   # If the user wants to install the dashboard,
   if [[ "${INSTALL_WEB}" == true ]]; then
     # do so
@@ -1614,9 +1591,7 @@ updatePihole() {
   # Install base files and web interface
   installScripts
   # Install config files
-  installConfigs
-  # Create the log file
-  CreateLogFile
+  installConfigs  
   # If the user wants to install the dasboard,
   if [[ "${INSTALL_WEB}" == true ]]; then
     # do so