add test for file permissions of $webroot

Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>

test/README.md

@@ -18,8 +18,8 @@ py.test -vv -n auto -m "build_stage"
 py.test -vv -n auto -m "not build_stage"
 ```
 
-The build_stage tests have to run first to create the docker images, followed by the actual tests which utilize said images.  Unless you're changing your dockerfiles you shouldn't have to run the build_stage every time - but it's a good idea to rebuild at least once a day in case the base Docker images or packages change.
+The build_stage tests have to run first to create the docker images, followed by the actual tests which utilize said images. Unless you're changing your dockerfiles you shouldn't have to run the build_stage every time - but it's a good idea to rebuild at least once a day in case the base Docker images or packages change.
 
 # How do I debug python?
 
-Highly recommended: Setup PyCharm on a **Docker enabled** machine.  Having a python debugger like PyCharm changes your life if you've never used it :)
+Highly recommended: Setup PyCharm on a **Docker enabled** machine. Having a python debugger like PyCharm changes your life if you've never used it :)

test/test_automated_install.py

@@ -111,6 +111,7 @@ def test_installPiholeWeb_fresh_install_no_errors(Pihole):
     confirms all web page assets from Core repo are installed on a fresh build
     '''
     installWeb = Pihole.run('''
+    umask 0027
     source /opt/pihole/basic-install.sh
     installPiholeWeb
     ''')
@@ -131,6 +132,69 @@ def test_installPiholeWeb_fresh_install_no_errors(Pihole):
     assert 'blockingpage.css' in web_directory
 
 
+def test_installPiholeWeb_fresh_install_readableBlockpage(Pihole):
+    '''
+    confirms all web page assets from Core repo are installed and readable by www-data on a fresh build
+    '''
+    installWeb = Pihole.run('''
+    umask 0027
+    source /opt/pihole/basic-install.sh
+    installPiholeWeb
+    ''')
+    expected_stdout = info_box + ' Installing blocking page...'
+    assert expected_stdout in installWeb.stdout
+    expected_stdout = tick_box + (' Creating directory for blocking page, '
+                                  'and copying files')
+    assert expected_stdout in installWeb.stdout
+    expected_stdout = info_box + ' Backing up index.lighttpd.html'
+    assert expected_stdout in installWeb.stdout
+    expected_stdout = ('No default index.lighttpd.html file found... '
+                       'not backing up')
+    assert expected_stdout in installWeb.stdout
+    expected_stdout = tick_box + ' Installing sudoer file'
+    assert expected_stdout in installWeb.stdout
+    exit_status_success = '0'
+    # check directories above $webroot for read and execute permission by www-data
+    check_var = 'echo $(sudo -u www-data test -r /var) $?'
+    expected_stdout = Pihole.run(check_var).stdout
+    assert exit_status_success in expected_stdout
+    check_var = 'echo $(sudo -u www-data test -x /var) $?'
+    expected_stdout = Pihole.run(check_var).stdout
+    assert exit_status_success in expected_stdout
+    check_www = 'echo $(sudo -u www-data test -r /var/www) $?'
+    expected_stdout = Pihole.run(check_www).stdout
+    assert exit_status_success in expected_stdout
+    check_www = 'echo $(sudo -u www-data test -x /var/www) $?'
+    expected_stdout = Pihole.run(check_www).stdout
+    assert exit_status_success in expected_stdout
+    check_html = 'echo $(sudo -u www-data test -r /var/www/html) $?'
+    expected_stdout = Pihole.run(check_html).stdout
+    assert exit_status_success in expected_stdout
+    check_html = 'echo $(sudo -u www-data test -x /var/www/html) $?'
+    expected_stdout = Pihole.run(check_html).stdout
+    assert exit_status_success in expected_stdout
+    # check directories below $webroot for read and execute permission by www-data
+    check_admin = 'echo $(sudo -u www-data test -r /var/www/html/admin) $?'
+    expected_stdout = Pihole.run(check_admin).stdout
+    assert exit_status_success in expected_stdout
+    check_admin = 'echo $(sudo -u www-data test -x /var/www/html/admin) $?'
+    expected_stdout = Pihole.run(check_admin).stdout
+    assert exit_status_success in expected_stdout
+    check_pihole = 'echo $(sudo -u www-data test -r /var/www/html/pihole) $?'
+    expected_stdout = Pihole.run(check_pihole).stdout
+    assert exit_status_success in expected_stdout
+    check_pihole = 'echo $(sudo -u www-data test -x /var/www/html/pihole) $?'
+    expected_stdout = Pihole.run(check_pihole).stdout
+    assert exit_status_success in expected_stdout
+    # check most important files in $webroot for read permission by www-data
+    check_index = 'echo $(sudo -u www-data test -r /var/www/html/admin/index.php) $?'
+    expected_stdout = Pihole.run(check_index).stdout
+    assert exit_status_success in expected_stdout
+    check_blockpage = 'echo $(sudo -u www-data test -r /var/www/html/admin/blockingpage.css) $?'
+    expected_stdout = Pihole.run(check_blockpage).stdout
+    assert exit_status_success in expected_stdout
+
+
 def test_update_package_cache_success_no_errors(Pihole):
     '''
     confirms package cache was updated without any errors