Pi-hole/pi-hole
Pi-hole/pi-hole
1
0
Fork 0
mirror of https://github.com/pi-hole/pi-hole.git synced 2024-11-15 02:42:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: yubiuser <ckoenig@posteo.de>

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
This commit is contained in:
Dan Schaper 2022-07-05 20:11:00 -07:00 committed by GitHub
parent ad70ece73e
commit 46f991f578
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
automated install/basic-install.sh
View file

@ -1179,12 +1179,12 @@ setLogging() {
case ${result} in case ${result} in
"${DIALOG_OK}") "${DIALOG_OK}")
# If they chose yes, # If they chose yes,
printf " %b Query Logging on.\\n" "${INFO}" printf " %b Query Logging on.\\n" "${INFO}"
QUERY_LOGGING=true QUERY_LOGGING=true
;; ;;
"${DIALOG_CANCEL}") "${DIALOG_CANCEL}")
# If they chose no, # If they chose no,
printf " %b Query Logging off.\\n" "${INFO}" printf " %b Query Logging off.\\n" "${INFO}"
QUERY_LOGGING=false QUERY_LOGGING=false
;; ;;
"${DIALOG_ESC}") "${DIALOG_ESC}")
@ -1232,13 +1232,13 @@ setAdminFlag() {
case ${result} in case ${result} in
"${DIALOG_OK}") "${DIALOG_OK}")
# If they chose yes, # If they chose yes,
printf " %b Installing Admin Web Interface\\n" "${INFO}" printf " %b Installing Admin Web Interface\\n" "${INFO}"
# Set the flag to install the web interface # Set the flag to install the web interface
INSTALL_WEB_INTERFACE=true INSTALL_WEB_INTERFACE=true
;; ;;
"${DIALOG_CANCEL}") "${DIALOG_CANCEL}")
# If they chose no, # If they chose no,
printf " %b Not installing Admin Web Interface\\n" "${INFO}" printf " %b Not installing Admin Web Interface\\n" "${INFO}"
# Set the flag to not install the web interface # Set the flag to not install the web interface
INSTALL_WEB_INTERFACE=false INSTALL_WEB_INTERFACE=false
INSTALL_WEB_SERVER=false INSTALL_WEB_SERVER=false
@ -1269,13 +1269,13 @@ the \"pihole\" group for full functionality." \
case ${result} in case ${result} in
"${DIALOG_OK}") "${DIALOG_OK}")
# If they chose yes, # If they chose yes,
printf " %b Installing lighttpd\\n" "${INFO}" printf " %b Installing lighttpd\\n" "${INFO}"
# Set the flag to install the web server # Set the flag to install the web server
INSTALL_WEB_SERVER=true INSTALL_WEB_SERVER=true
;; ;;
"${DIALOG_CANCEL}") "${DIALOG_CANCEL}")
# If they chose no, # If they chose no,
printf " %b Not installing lighttpd\\n" "${INFO}" printf " %b Not installing lighttpd\\n" "${INFO}"
# Set the flag to not install the web server # Set the flag to not install the web server
INSTALL_WEB_SERVER=false INSTALL_WEB_SERVER=false
;; ;;
@ -1307,12 +1307,12 @@ chooseBlocklists() {
case ${result} in case ${result} in
"${DIALOG_OK}") "${DIALOG_OK}")
# If they chose yes, # If they chose yes,
printf " %b Installing StevenBlack's Unified Hosts List\\n" "${INFO}" printf " %b Installing StevenBlack's Unified Hosts List\\n" "${INFO}"
echo "https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts" >> "${adlistFile}" echo "https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts" >> "${adlistFile}"
;; ;;
"${DIALOG_CANCEL}") "${DIALOG_CANCEL}")
# If they chose no, # If they chose no,
printf " %b Not installing StevenBlack's Unified Hosts List\\n" "${INFO}" printf " %b Not installing StevenBlack's Unified Hosts List\\n" "${INFO}"
;; ;;
"${DIALOG_ESC}") "${DIALOG_ESC}")
# User pressed <ESC> # User pressed <ESC>