From 47bbea9ba71faea5669aa75526e1ab66d1164b30 Mon Sep 17 00:00:00 2001 From: Ludovic Rousseau Date: Sun, 18 Feb 2018 21:18:52 +0100 Subject: [PATCH] Use " " to protect parameter substitution Signed-off-by: Ludovic Rousseau --- advanced/Scripts/list.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/advanced/Scripts/list.sh b/advanced/Scripts/list.sh index 106f5caf..1d96ea3c 100755 --- a/advanced/Scripts/list.sh +++ b/advanced/Scripts/list.sh @@ -10,9 +10,9 @@ # Globals basename=pihole -piholeDir=/etc/${basename} -whitelist=${piholeDir}/whitelist.txt -blacklist=${piholeDir}/blacklist.txt +piholeDir=/etc/"${basename}" +whitelist="${piholeDir}"/whitelist.txt +blacklist="${piholeDir}"/blacklist.txt readonly wildcardlist="/etc/dnsmasq.d/03-pihole-wildcard.conf" reload=false addmode=true @@ -80,13 +80,13 @@ HandleOther() { PoplistFile() { # Check whitelist file exists, and if not, create it - if [[ ! -f ${whitelist} ]]; then - touch ${whitelist} + if [[ ! -f "${whitelist}" ]]; then + touch "${whitelist}" fi # Check blacklist file exists, and if not, create it - if [[ ! -f ${blacklist} ]]; then - touch ${blacklist} + if [[ ! -f "${blacklist}" ]]; then + touch "${blacklist}" fi for dom in "${domList[@]}"; do