From 64b91c8b971034a3ad0c3b2958249eaddaa36d58 Mon Sep 17 00:00:00 2001 From: Dan Schaper Date: Sun, 2 Oct 2016 11:31:12 -0700 Subject: [PATCH] `with` open logfile for Python autohandling of closure. --- advanced/Scripts/dnsmasq_parse.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/advanced/Scripts/dnsmasq_parse.py b/advanced/Scripts/dnsmasq_parse.py index 2d0968b6..6bef879f 100644 --- a/advanced/Scripts/dnsmasq_parse.py +++ b/advanced/Scripts/dnsmasq_parse.py @@ -154,15 +154,16 @@ with conn: create_tables() # Parse the log file. - for line in open(logfile): - line = line.rstrip() + with open(logfile) as f: + for line in f: + line = line.rstrip() - if ': query[' in line: - parse_query(line) + if ': query[' in line: + parse_query(line) - elif ': forwarded ' in line: - parse_forward(line) + elif ': forwarded ' in line: + parse_forward(line) - elif (': reply ' in line) or (': cached ' in line): - parse_reply(line) + elif (': reply ' in line) or (': cached ' in line): + parse_reply(line)