mirror of
https://github.com/pi-hole/pi-hole.git
synced 2024-12-23 21:30:17 +00:00
add a comment about bash vs dash. future refact needed
This commit is contained in:
parent
05e114173d
commit
699e299345
1 changed files with 3 additions and 0 deletions
|
@ -110,5 +110,8 @@ def run_script(Pihole, script, file="/test.sh"):
|
|||
def _write_test_script(Pihole, script, file):
|
||||
''' Running the test script blocks directly can behave differently with regard to global vars '''
|
||||
''' this is a cheap work around to that until all functions no longer rely on global variables '''
|
||||
''' found out why, dash: is the default in testinfra run() for Docker
|
||||
Should try and convert the tests using this to firewalld style test
|
||||
or override the run() function to use bash instead '''
|
||||
Pihole.run('cat <<EOF> {file}\n{script}\nEOF'.format(file=file, script=script))
|
||||
Pihole.run('chmod +x {}'.format(file))
|
||||
|
|
Loading…
Reference in a new issue