mirror of
https://github.com/pi-hole/pi-hole.git
synced 2024-12-25 06:10:20 +00:00
Replace use of grep -w with grep -x.
Prepend "^" to start of latentWhitelist.txt lines. The -x switch requires a full line match of the regexp, where as -w will try to find the match somewhere in the line, looking for work breaks. Combined with turning the whitelist lines into full regexps, this results in significantly faster parsing. Having "^" prepended to the lines also keeps false whitelisting from occuring, such as the following example: If whitelist.txt contains "google.com" it would whitelist many other sites that end in "google.com" as long as there is a non-word character preceeding the google (such as "-", or ".").
This commit is contained in:
parent
a26377d229
commit
98c94912e1
1 changed files with 7 additions and 4 deletions
11
gravity.sh
11
gravity.sh
|
@ -115,8 +115,10 @@ if [[ -f $whitelist ]];then
|
||||||
numberOf=$(cat $whitelist | sed '/^\s*$/d' | wc -l)
|
numberOf=$(cat $whitelist | sed '/^\s*$/d' | wc -l)
|
||||||
plural=; [[ "$numberOf" != "1" ]] && plural=s
|
plural=; [[ "$numberOf" != "1" ]] && plural=s
|
||||||
echo "** Whitelisting $numberOf domain${plural}..."
|
echo "** Whitelisting $numberOf domain${plural}..."
|
||||||
# Append a "$" to the end of each line so it can be parsed out with grep -w
|
# Append a "$" to the end, prepend a "^" to the beginning, and
|
||||||
awk -F '[# \t]' 'NF>0&&$1!="" {print $1"$"}' $whitelist > $latentWhitelist
|
# replace "." with "\." of each line to turn each entry into a
|
||||||
|
# regexp so it can be parsed out with grep -x
|
||||||
|
awk -F '[# \t]' 'NF>0&&$1!="" {print "^"$1"$"}' $whitelist | sed 's/\./\\./g' > $latentWhitelist
|
||||||
else
|
else
|
||||||
rm $latentWhitelist
|
rm $latentWhitelist
|
||||||
fi
|
fi
|
||||||
|
@ -126,8 +128,9 @@ plural=; [[ "${#sources[@]}" != "1" ]] && plural=s
|
||||||
echo "** Whitelisting ${#sources[@]} ad list source${plural}..."
|
echo "** Whitelisting ${#sources[@]} ad list source${plural}..."
|
||||||
for url in ${sources[@]}
|
for url in ${sources[@]}
|
||||||
do
|
do
|
||||||
echo "$url" | awk -F '/' '{print $3"$"}' >> $latentWhitelist
|
echo "$url" | awk -F '/' '{print "^"$3"$"}' | sed 's/\./\\./g' >> $latentWhitelist
|
||||||
done
|
done
|
||||||
grep -vwf $latentWhitelist $origin/$matter > $origin/$andLight
|
|
||||||
|
grep -vxf $latentWhitelist $origin/$matter > $origin/$andLight
|
||||||
|
|
||||||
gravity_advanced
|
gravity_advanced
|
||||||
|
|
Loading…
Reference in a new issue