Pi-hole/pi-hole
Pi-hole/pi-hole
1
0
Fork 0
mirror of https://github.com/pi-hole/pi-hole.git synced 2024-11-23 06:33:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add warning on checkout core tags <v5.17

Browse source 
Signed-off-by: Christian König <ckoenig@posteo.de>
This commit is contained in:
Christian König 2023-05-13 09:34:18 +02:00
parent ff91db7b9a
commit c31705086a
No known key found for this signature in database
1 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
advanced/Scripts/piholeCheckout.sh
View file

@ -38,6 +38,23 @@ warning1() {
esac esac
} }
warning2() {
echo ""
echo " ${INFO} Your are trying to checkout the tag ${1} for Pihole's core component"
echo " ${COL_LIGHT_RED}Please note that checking out core tags before v5.17 will break your installation${COL_NC}"
read -r -p " Proceed anyway? [y/N] " response
case "${response}" in
[yY][eE][sS]|[yY])
echo ""
return 0
;;
*)
echo -e "\\n ${INFO} Branch/Tag change has been canceled"
return 1
;;
esac
}
fully_fetch_repo() { fully_fetch_repo() {
# Add upstream branches/tags to shallow clone # Add upstream branches/tags to shallow clone
local directory="${1}" local directory="${1}"
@ -97,7 +114,7 @@ checkout_pull_ref() {
oldref="$(git symbolic-ref --quiet HEAD)" oldref="$(git symbolic-ref --quiet HEAD)"
str="Switching to branch/tag: '${ref}' from '${oldref}'" str="Switching to branch/tag: '${ref}' from '${oldref}'"
printf " %b %s" "${INFO}" "$str" printf " %b %s\\n" "${INFO}" "$str"
# check if the ref is a branch or a tag on the remote repo # check if the ref is a branch or a tag on the remote repo
if git show-ref -q --verify "refs/remotes/origin/$ref" 2>/dev/null; then if git show-ref -q --verify "refs/remotes/origin/$ref" 2>/dev/null; then
@ -107,6 +124,13 @@ checkout_pull_ref() {
fi fi
if [ "$ref_is_tag" = true ]; then if [ "$ref_is_tag" = true ]; then
# In case we are checking out tags on 'core' show an additional warning and allow to cancel checkout
if [ "${directory}" = "${PI_HOLE_FILES_DIR}" ]; then
if ! warning2 "${ref}" ; then
exit 1
fi
fi
# in case we want to checkout a tag we need explicitly create a new branch/reset the existing one # in case we want to checkout a tag we need explicitly create a new branch/reset the existing one
git checkout -B "${ref}" "refs/tags/${ref}" --quiet || return 1 git checkout -B "${ref}" "refs/tags/${ref}" --quiet || return 1
printf "%b %b %s\\n" "${OVER}" "${TICK}" "$str" printf "%b %b %s\\n" "${OVER}" "${TICK}" "$str"