mirror of
https://github.com/pi-hole/pi-hole.git
synced 2024-11-15 02:42:58 +00:00
Moved file creation to proper function. Included bash variables for file
location. Set to pihole:pihole ownership with 644 permissions. Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
This commit is contained in:
parent
17c1e64f7e
commit
d0d030bafc
1 changed files with 12 additions and 9 deletions
|
@ -1219,13 +1219,7 @@ installScripts() {
|
|||
install -o "${USER}" -Dm755 -t /usr/local/bin/ pihole
|
||||
install -Dm644 ./advanced/bash-completion/pihole /etc/bash_completion.d/pihole
|
||||
echo -e "${OVER} ${TICK} ${str}"
|
||||
# Install template if it does not exist
|
||||
if [[ ! -f "/etc/pihole/pihole-FTL.conf" ]]; then
|
||||
if ! sudo -u ${USER} touch "${PI_HOLE_INSTALL_DIR}/pihole-FTL.conf" 2&>1 /dev/null; then
|
||||
echo -e " ${COL_LIGHT_RED}Error: Unable to initialize configuration file /etc/pihole/pihole-FTL.conf"
|
||||
return 1
|
||||
fi
|
||||
fi
|
||||
|
||||
# Otherwise,
|
||||
else
|
||||
# Show an error and exit
|
||||
|
@ -1241,7 +1235,13 @@ installConfigs() {
|
|||
echo -e " ${INFO} Installing configs from ${PI_HOLE_LOCAL_REPO}..."
|
||||
# Make sure Pi-hole's config files are in place
|
||||
version_check_dnsmasq
|
||||
|
||||
# Install template if it does not exist
|
||||
if [[ ! -f "${PI_HOLE_INSTALL_DIR}/pihole-FTL.conf" ]]; then
|
||||
if ! install -o pihole -g pihole -m 664 /dev/null "${PI_HOLE_INSTALL_DIR}/pihole-FTL.conf" &>/dev/nul; then
|
||||
echo -e " ${COL_LIGHT_RED}Error: Unable to initialize configuration file ${PI_HOLE_INSTALL_DIR}/pihole-FTL.conf"
|
||||
return 1
|
||||
fi
|
||||
fi
|
||||
# If the user chose to install the dashboard,
|
||||
if [[ "${INSTALL_WEB_SERVER}" == true ]]; then
|
||||
# and if the Web server conf directory does not exist,
|
||||
|
@ -1782,7 +1782,10 @@ installPihole() {
|
|||
exit 1
|
||||
fi
|
||||
# Install config files
|
||||
installConfigs
|
||||
if ! installConfigs; then
|
||||
echo -e " {CROSS} Failure in dependent config copy function."
|
||||
exit 1
|
||||
fi
|
||||
# If the user wants to install the dashboard,
|
||||
if [[ "${INSTALL_WEB_INTERFACE}" == true ]]; then
|
||||
# do so
|
||||
|
|
Loading…
Reference in a new issue