bcambl
cbf84c1840
replace subshell with command chain
2016-12-22 04:32:42 -06:00
bcambl
c9c28cb59a
replace 'git -C' with long version
...
The -C argument was introduced in git 1.8.4. CentOS 7.3 at the time of this commit provides v1.8.3.1.
see: https://git.kaarsemaker.net/git/commit/44e1e4d67d5148c245db362cc48c3cc6c2ec82ca/
Fixes #1004
2016-12-22 03:37:34 -06:00
Dan Schaper
4244f716e0
Create /opt/pihole before trying to install into it.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2016-12-21 23:04:57 -08:00
DL6ER
c48e6c91f5
Merge pull request #999 from pi-hole/fix/install_deps_exit
...
Fix/install deps exit
2016-12-21 16:00:48 +01:00
DL6ER
8841bdd252
Reset the if's
2016-12-21 12:57:02 +01:00
DL6ER
58261098fb
We should not call a function that Dan deleted
2016-12-21 12:07:44 +01:00
DL6ER
9432d3035a
Merge branch 'development' into cleanup/remove_legacy_detect
...
Conflicts:
automated install/basic-install.sh
2016-12-21 12:01:58 +01:00
DL6ER
9907fc2770
Merge branch 'development' into fix/install_deps_exit
...
Conflicts:
automated install/basic-install.sh
2016-12-21 11:54:52 +01:00
Dan Schaper
8117ec8e20
Remove v1 legacy detection code.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2016-12-20 17:50:44 -08:00
Dan Schaper
ff2783f9fc
Tabs to spaces and formatting.
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 17:22:57 -08:00
Dan Schaper
156a51c945
Remove extra display only variable.
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 17:04:46 -08:00
Dan Schaper
c72ffae4a2
Don't install extra packages (openresolv was installed over resolvconf). No longer need --fix-missing.
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 17:02:51 -08:00
Dan Schaper
7f3b0030ea
LF
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 16:47:43 -08:00
Dan Schaper
9a626948f8
Use debconf for Deb/Ubu package installations.
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
Alphabetic sort of dependency names
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 16:22:31 -08:00
Dan Schaper
5c43df66a8
Remove spinner function, masked return values.
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 16:22:08 -08:00
Dan Schaper
d0e3c546f8
CRLF to CR (Win to Unix line endings)
...
Signed-off-by: Dan Schaper <dschaper@ganymeade.com>
2016-12-20 15:00:37 -08:00
Dan Schaper
8cb01cdd29
One step to rename variables.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2016-12-16 15:08:30 -08:00
Adam Warner
10982a0f45
Merge pull request #990 from pi-hole/dontkillsetupVars.conf
...
Don't kill setupVars.conf on update/fresh install
2016-12-16 13:55:33 +00:00
DL6ER
d4c378ed5d
Remove PIHOLE_INTERFACE if already set (not PIHOLE_DOMAIN)
2016-12-16 13:20:25 +01:00
DL6ER
7872f68a45
Only try to remove parts inthe file if the file already exists
2016-12-16 13:13:35 +01:00
DL6ER
ec8c848106
Don't kill already existing setupVars.conf on update (and fresh install)
2016-12-16 12:53:00 +01:00
Mcat12
3b50ce8c54
Merge pull request #977 from pi-hole/activatewebUIpw
...
Add password to webUI after update if there is none
2016-12-15 14:05:11 -05:00
DL6ER
1eeaa01234
Always put the information that we added a password if we did (not only on update but also on fresh install)
2016-12-15 15:22:44 +01:00
DL6ER
e2898217d2
Made message shorter
2016-12-15 15:20:41 +01:00
DL6ER
f81dadc5d0
Fix final message
2016-12-15 14:10:55 +01:00
Promofaux
c10ec5548f
remove code that replaces tokens in 01-pihole.conf
2016-12-14 19:29:44 +00:00
Mcat12
92f4824884
Automatically enable IPv6
2016-12-14 13:52:14 -05:00
DL6ER
a00034a6a7
Add password to webUI after update if there is none
2016-12-12 17:03:53 +01:00
trinapicot
0a423ffd40
Fix check for lighttpd install before configuration directory removal
2016-12-07 20:31:34 -07:00
DL6ER
5374f652dd
No need to modify lighttpd config file, since we overwrite it anyways
2016-12-06 08:43:24 +01:00
DL6ER
a866c4e388
Place blockingpage.css (former index.css) unter admin/ so we can load it also from some blocked sub-directories
2016-12-05 10:50:19 +01:00
DL6ER
e7241a989c
Include CSS file
2016-12-04 22:20:51 +01:00
DL6ER
b246dba7e7
Rename index.html to index.php
2016-12-04 21:41:26 +01:00
trinapicot
870454330d
Add check for lighty.conf before trying to move it
2016-12-02 13:54:11 -07:00
Dan Schaper
d53a3af191
Merge pull request #899 from diginc/configureFirewall_unittest
...
Configure firewall unittest
2016-11-19 11:07:38 -08:00
Mcat12
bd61f38169
Merge pull request #926 from zbholman/patch-2
...
Added removal of pihole user to the uninstall.sh
2016-11-16 17:31:56 -05:00
zbholman
cac9c63325
Added removal of pihole user to the uninstall.sh
...
Not sure if I should have created a variable for the username or if the echo is necessary. And this is my first time doing a pull request, hopefully it works out lol.
2016-11-16 17:06:30 -05:00
Hayden Knowles
86d3ca48ae
moved newline to correct place
2016-11-15 22:40:57 +13:00
Dan Schaper
e9475a9739
Merge pull request #887 from brontide/dependancy_cleanup
...
Dependancy cleanup
2016-11-07 21:45:23 -08:00
bcambl
0caa44e979
write ifcfg instead of appending
2016-11-07 12:54:31 -06:00
diginc
b9f3493dbc
move PH_TRUE to Dockerfiles to DRY
2016-11-03 22:34:04 -05:00
diginc
633095aee1
switch to consistent style
2016-11-02 22:13:05 -05:00
Eric Warnke
71005e1db3
Merge with change of spacing in development
2016-11-02 19:01:34 -04:00
Promofaux
c452a4569e
.js
2016-11-02 21:17:00 +00:00
Promofaux
a182a208dc
Tidy up output
2016-11-02 21:06:12 +00:00
Promofaux
d273b4b48b
Check for missing index.html, replace if missing.
2016-11-02 20:57:56 +00:00
Promofaux
b429e890ad
move web interface message inside "if not update" block. Check for pi-hole deps AFTER whiptails
2016-11-02 20:16:36 +00:00
Dan Schaper
6d415a7384
Merge pull request #894 from diginc/InstallFixes_UnitTests
...
Unit tests framework and some basic tests
2016-11-02 09:42:20 -07:00
Dan Schaper
8b9f0487c0
Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
...
# Conflicts:
# advanced/Scripts/update.sh
# automated install/basic-install.sh
2016-11-02 06:57:33 -07:00
Adam Warner
50bd8b4a09
Further tweaks to local repo handling
2016-11-02 13:34:57 +00:00
Dan Schaper
7740e4268c
Consistency and standards basic-install start.
2016-11-02 05:17:28 -07:00
Adam Warner
3df2ef8587
Cherry picking f6f6f6d
, conflict fix
2016-11-02 04:31:28 -07:00
Adam Warner
354309fcad
set QUERY_LOGGING default to true
2016-11-02 04:28:58 -07:00
Adam Warner
edd00e8e70
consistency
2016-11-02 04:12:37 -07:00
Adam Warner
82e7de2aaa
Account for variable name changes
2016-11-02 04:12:21 -07:00
Adam Warner
b723714c0c
Convention : https://google.github.io/styleguide/shell.xml?showone=Constants_and_Environment_Variable_Names#Constants_and_Environment_Variable_Names
2016-11-02 04:12:06 -07:00
Adam Warner
a2903b6e63
Consistency
2016-11-02 04:11:54 -07:00
Dan Schaper
9a1876571b
Prototype whiptails
so they don't fall to shell. Need to do this to all functions.
2016-11-02 04:11:41 -07:00
Dan Schaper
c07d7165ab
Global variables CAP'ed
2016-11-02 04:11:27 -07:00
Dan Schaper
d695c5972f
local
variables just to be safe and make sure they stay in this function.
2016-11-02 04:11:09 -07:00
Dan Schaper
bbc09ed313
Swap variable names.
2016-11-02 04:10:57 -07:00
Promofaux
617a147706
Wording adjustment
2016-11-02 04:10:29 -07:00
Promofaux
d4dccfdb2d
Cherry pick 229439c
2016-11-02 04:08:53 -07:00
Dan Schaper
d9528dfd09
Bash is funny with returns.
2016-11-02 00:51:38 -07:00
Dan Schaper
12f5f8ba00
Begin to bring code up to Pi-hole conventions. Block installScripts and begin factoring out redundant code.
2016-11-02 00:14:25 -07:00
Dan Schaper
db0f3307e0
Only take out scripts in the directory, don't remove the directory as a whole. Need this for the future installs.
2016-11-01 22:48:30 -07:00
Dan Schaper
7a22471787
New naming convention, and reorder functions as bash would prefer them to be.
2016-11-01 22:19:40 -07:00
diginc
b4524839bb
Merge branch 'development' of https://github.com/pi-hole/pi-hole into InstallFixes_UnitTests
2016-11-01 23:52:20 -05:00
Eric Warnke
fb5ac6d6d7
We should prefer the php metapackage if it's there, falling back on php5 if it's not
2016-10-31 21:31:13 -04:00
Eric Warnke
4e7ca51beb
Added dependancy for ping and lsof used in debug scripts
2016-10-31 21:24:57 -04:00
Eric Warnke
65e0fcbf10
Merge branch 'development' of https://github.com/pi-hole/pi-hole into wheezy_fix2
2016-10-28 13:14:00 -04:00
Dan Schaper
e22aca49c8
Merge pull request #813 from das7pad/development
...
Create missing directory for lighttpd
2016-10-28 10:05:08 -07:00
Adam Warner
21fc6344bf
Merge pull request #849 from pi-hole/aManHasNoNameResolution
...
[BugFix] A man has no name resolution
2016-10-27 19:41:07 +01:00
Promofaux
794fa21137
install uninstall.sh...
2016-10-27 12:44:21 +01:00
Eric Warnke
977d1d1998
Merge branch 'development' of https://github.com/pi-hole/pi-hole into wheezy_fix2
2016-10-27 07:37:40 -04:00
Promofaux
cde003bc98
\ all the /s!
2016-10-27 11:13:00 +01:00
Adam Warner
3996e11425
Merge pull request #859 from pi-hole/ImproveWhitelistBlacklist
...
Improvements to White and Blacklists
2016-10-26 19:52:16 +01:00
Eric Warnke
3a4fe3e391
Wheezy install fix by selecting appropriate deps, made the php check the same
2016-10-26 14:47:29 -04:00
Eric Warnke
4ed6e4d016
Tiny screens get sane minimums
2016-10-26 11:15:02 -04:00
Eric Warnke
ac8d24a1ce
Even with no detected screen size, it should presume 80x24
2016-10-26 11:14:54 -04:00
Eric Warnke
fc776921d5
stty is more compatible and does not require any additional dependancies for busybox
2016-10-26 11:14:46 -04:00
Adam Warner
55a653aca4
clear out /opt/pihole folder before installing scripts
2016-10-26 10:00:00 +01:00
Adam Warner
bd0db56ba0
actually fix up logic
2016-10-25 15:29:02 +01:00
Adam Warner
95f0b3710d
fix up logic
2016-10-25 15:27:13 +01:00
Adam Warner
86349527e7
replace HOSTNAME tokens in 01-pihole.conf
2016-10-25 15:06:37 +01:00
Adam Warner
911053f63f
Replace IPv4 and IPv6 tokens in 01-pihole.conf for pi.hole resolution.
2016-10-25 15:00:18 +01:00
Marcus Hildum
519d731ddd
Fix missing newline
...
My mistake
2016-10-23 16:45:51 -07:00
Marcus Hildum
ec4f5007e7
remove bad {
2016-10-21 23:59:31 -07:00
Marcus Hildum
21b906e0e0
Consistency
...
More of the same
2016-10-21 23:57:47 -07:00
Marcus Hildum
7ebaf8e843
Consistency
...
Now with block indents!
2016-10-21 23:23:31 -07:00
Marcus Hildum
28eeaf201b
Standardize function declaration
...
There were no fewer than three styles of function declaration going
on in these files, so I attempted to standardize them to the typical
myfucn() {
}
style.
2016-10-19 19:47:45 -07:00
Jakob Ackermann
8872594ab9
create upload dir for lighttpd
...
directory is missing in the installation process but is used in the
lighttpd.conf
2016-10-19 14:27:17 +02:00
Adam Warner
ff5d5b97c3
stash any changes in local repo
2016-10-18 13:54:09 +01:00
Dan Schaper
ef3c13fe2b
Refire with curl
2016-10-17 19:22:56 -07:00
bcambl
fb9664b636
fix typo
2016-10-16 15:11:47 -06:00
bcambl
ee114b3075
use an excluded extension for ifcfg backup
2016-10-16 13:28:14 -06:00
Promofaux
5792fc0bef
change wording depending on choice
2016-10-16 17:23:26 +01:00
Promofaux
42c93917ef
bug I forgot to fix before piholeUpdate was merged to development
2016-10-16 17:19:44 +01:00
Adam Warner
df30a4c0d1
Merge pull request #779 from bcambl/fedora_fixes
...
Fedora fixes
2016-10-16 15:46:50 +01:00
Adam Warner
9ce13f0035
Merge pull request #790 from pi-hole/piholeUpdate
...
Various refactoring.
2016-10-15 23:51:07 +01:00
Promofaux
3884b01503
Forgot a
2016-10-15 23:21:13 +01:00
Promofaux
a84c3adeab
if uniformity then dan = happy
2016-10-15 23:19:26 +01:00
Promofaux
a65b784907
repeat after me: repetition is a bit repetitive.
2016-10-15 21:26:41 +01:00
Promofaux
05dadad2e1
repair sounds better than refresh
2016-10-15 21:22:46 +01:00
Promofaux
3a9b39b842
adjust text in update_dialogs() whiptail
2016-10-15 21:12:13 +01:00
Promofaux
e612003293
handle arguments better, convert to flags, echo when they're set to true.
2016-10-15 20:52:20 +01:00
Promofaux
a43577fa26
add reconfigure flag to -r command
2016-10-15 20:43:03 +01:00
Promofaux
a6fa60868b
spacing
2016-10-15 15:41:48 +01:00
Promofaux
99878ae7d6
reflect name change of some of the variables in setupVars
2016-10-15 15:40:12 +01:00
bcambl
26202014a2
stdout formatting
2016-10-12 20:35:08 -06:00
bcambl
f4f8b96788
remove systemd selinux rules on init systems
...
fixes the failing SELinux policy compile on init based systems
2016-10-12 20:35:08 -06:00
bcambl
e5ede16749
update yum/dnf package count grepfu
...
see pull #774
2016-10-12 20:33:13 -06:00
bcambl
fbe3547129
EPEL is not required on Fedora
...
epel-release installs the EPEL package repository (Extra Packages for Enterprise Linux)
Dependencies from this repository should available by default on Fedora
2016-10-12 20:26:48 -06:00
diginc
a03caea549
setupVar tests passing for debian & centos
2016-10-10 23:14:39 -05:00
Promofaux
aa23fb1d56
choose*
2016-10-10 22:34:12 +01:00
Dan Schaper
570611fc09
CentOS Firewall fix
2016-10-10 11:30:15 -07:00
Dan Schaper
94dd5b1ebe
More CentOS fixes.
2016-10-10 11:05:29 -07:00
Dan Schaper
74524e024d
Always check PIHOLE_dependencies.
2016-10-10 10:36:19 -07:00
Dan Schaper
e42b6dcc8e
create_pihole_user update @diginc.
2016-10-10 09:21:28 -07:00
Dan Schaper
d71b799e75
More cleanups, localize variables, clean formatting.
2016-10-10 08:23:14 -07:00
Dan Schaper
87e7121332
Gravity.sh checks for null value for variables, obliging that expectation.
2016-10-10 07:32:16 -07:00
Dan Schaper
94f6354c94
Spinner blocks set -e
trying to get it in functions that won't crash out...
2016-10-10 07:25:43 -07:00
Dan Schaper
b79059ebdb
Start to add the spinner back in!
2016-10-10 06:46:30 -07:00
Dan Schaper
4f98c1bebb
Boolean operators inside quotes don't work well...
2016-10-10 06:16:00 -07:00
Dan Schaper
2feec01e10
Add start_service
and enable_service
functions to handle restating services and setting services to start on reboot.
2016-10-10 06:06:34 -07:00
Dan Schaper
72b95e192e
Fix logic bug in setup_user
, update how setupVars are sourced so they will only be used if the user selects update
and not if they select install
.
2016-10-10 05:45:37 -07:00
Dan Schaper
47aad254d8
localized some more variables
2016-10-10 03:56:03 -07:00
Dan Schaper
bc14074d2a
Tighten up Update Whiptail appearance.
2016-10-10 03:39:32 -07:00
Dan Schaper
5ab5b1a190
Overhaul dnsmasq version 3 way handshake configuration files.
2016-10-10 03:23:52 -07:00
Dan Schaper
b055f190f5
Factor out interfaces detection.
2016-10-10 03:16:22 -07:00
Dan Schaper
84b8953352
Remove quiet flags from package managment variables. Set quiets in functions by redirecting output.
2016-10-10 02:58:38 -07:00
Dan Schaper
93a591d487
Linting from ShellCheck
2016-10-10 02:57:04 -07:00
Dan Schaper
e6c0f38a7c
Monolithic changes in one commit again.
2016-10-10 02:24:03 -07:00
Dan Schaper
f107ae4f9b
Merge conflict resolution
2016-10-10 09:08:25 +00:00
Dan Schaper
bad7a08804
Refactor and rename create_pihole_user
. Now to actually use the user created...
2016-10-10 01:51:19 -07:00
Dan Schaper
25cbf4cb35
Factor out legacy location script removal.
2016-10-10 01:43:10 -07:00
Dan Schaper
7f179f9a58
Remove sourcing bash completion, would fall off as soon as the subshell terminated.
2016-10-10 01:40:56 -07:00
Dan Schaper
5287ea8537
Refactor stopServices
into stop_service
and accept arguments for service to stop. Quiet output from a few other functions.
2016-10-10 01:25:11 -07:00
Dan Schaper
43e2aaebf0
rename updateDialogs
to update_dialogs
2016-10-10 01:04:59 -07:00
Dan Schaper
e60eb66283
UpdateDialogs are now a Whiptail Menu, self-explanatory.
2016-10-10 01:04:03 -07:00
Dan Schaper
ca59b808d8
Git clone/update now occurs right after installer dependency checks. Allows for inclusion of installer source files in the repo. Passes set -e
2016-10-10 00:02:50 -07:00
Dan Schaper
8a15fd44d5
Update is_repo()
to use git status
for validity checks.
2016-10-09 23:53:18 -07:00
Dan Schaper
dac2b8942e
Typo fix to generate commit.
2016-10-09 22:38:00 -07:00
Dan Schaper
54a1c5b63a
Revert inadvertent commits
...
IDLE keeps committing direct to development.
2016-10-09 22:35:14 -07:00
Dan Schaper
61b02bf6d3
Add OR TRUE to PKG_COUNT so that a 0 package to update doesn't grep -c to an exit value of 1.
2016-10-09 22:27:37 -07:00
Dan Schaper
9d048b2fdf
Move Pi-hole dependency checks to main()
and out of duplicated install
and update
functions. Bring them up a level in the subshells.
2016-10-09 22:24:13 -07:00
Dan Schaper
d9e28a7422
factor out installer_dependencies
2016-10-09 22:05:06 -07:00
Dan Schaper
1fecdf42ca
Move git
to installer deps, refactor some functions.
2016-10-09 22:00:23 -07:00
Dan Schaper
d4bf85b67c
Self contain package_check
into package_check_install
. Passes set -e
test.
2016-10-09 21:44:45 -07:00
Dan Schaper
7131ff27c3
Attempt to set -e
2016-10-09 21:32:25 -07:00