Adam Warner
fc83883934
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de>
Signed-off-by: Adam Warner <github@adamwarner.co.uk>
2022-12-11 17:48:45 +00:00
RD WebDesign
1550f29f06
Use GREEN if dig was successful
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-12-11 14:42:47 -03:00
RD WebDesign
a206980242
Fix parenthesis color
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-12-11 14:42:47 -03:00
RD WebDesign
8c2f56b0e6
Imporving the output from os_check()
function
...
- add red color to dig errors
- reorder some output lines
- add "Distro and version supported" on success
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-12-11 14:42:46 -03:00
RD WebDesign
b4349b41ce
Use the correct variable digReturnCode
...
also use INFO instead of CROSS, because it's not an error.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-12-11 14:42:46 -03:00
RD WebDesign
67f04787d6
Only compare OS versions if dig
was successful
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-12-11 14:42:35 -03:00
Adam Warner
1ee922d16c
Disable a few commands if installed in (official) docker containers ( #5018 )
2022-12-11 17:31:58 +00:00
Adam Warner
c2bb190dce
Explicitly create group pihole on installation ( #5039 )
2022-12-11 14:05:24 +00:00
Adam Warner
b8eae60fcc
Disable a few commands for Docker. Currently this is done by monkeypatching the the pihole
file on Docker install, however if someone was to run pihole checkout, these patches are removed.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2022-12-11 11:39:11 +00:00
Dan Schaper
c86ff5d084
Bump actions/setup-python from 4.3.0 to 4.3.1 ( #5054 )
2022-12-10 12:39:11 -08:00
dependabot[bot]
126da094bd
Bump actions/setup-python from 4.3.0 to 4.3.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.3.0...v4.3.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-12-10 10:00:58 +00:00
Dan Schaper
a4e20f79a3
Install wheel before other python packages in Action ( #5048 )
2022-12-05 15:32:04 -08:00
Christian König
6b146ed2d1
Use two-step approach
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-12-05 23:13:24 +01:00
Christian König
e0e0baf076
Install wheel before other python packages
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-12-04 09:32:23 +01:00
Dan Schaper
95e799ed6e
Do not require man pages to be present in test script ( #5037 )
...
Skip manpage tests when the manpage directory does not exist.
2022-11-28 13:27:30 -08:00
DL6ER
202aa25c09
Do not setcap FTL binary when systemd is used ( #5043 )
...
All bets on `AmbientCapabilities`
2022-11-28 22:00:27 +01:00
MichaIng
06de172952
Skip setcap on installs with systemd
...
since the systemd unit uses "AmbientCapabilities" to grant capabilities.
Signed-off-by: MichaIng <micha@dietpi.com>
Signed-off-by: MichaIng <micha@dietpi.com>
2022-11-28 21:27:57 +01:00
Adam Warner
ff5ee29566
Add native systemd service ( #4924 )
2022-11-27 21:41:35 +00:00
Adam Warner
d393497641
sync: master to development ( #5041 )
2022-11-27 21:40:52 +00:00
Adam Warner
0034538794
v5.14.2 ( #5040 )
2022-11-27 21:31:19 +00:00
Christian König
33d2163f19
Explicitly create group pihole on installation
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-24 22:06:04 +01:00
Christian König
ea26171c18
Do not require man pages to be present in test script
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-24 20:39:02 +01:00
Dan Schaper
82dfcbcd83
Fix pihole updatecheck reboot ( #5035 )
2022-11-23 11:08:46 -08:00
RD WebDesign
233453267e
Using shift
to allow passing multiple arguments
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-11-23 15:33:49 -03:00
RD WebDesign
f3c27f706f
Pass only the correct argument
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-11-23 14:07:30 -03:00
Dan Schaper
983d79b3e6
Don't install which
( #5028 )
2022-11-18 17:40:12 -08:00
Christian König
6d8abc2e30
Don't install which
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-18 23:50:34 +01:00
Adam Warner
38775cffdf
Ensure local hash is always of length 8, for consistency.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2022-11-14 22:51:39 +00:00
Adam Warner
b13a75a223
sync: master to development ( #5017 )
2022-11-14 22:46:26 +00:00
Adam Warner
21026d9414
Fix odd behaviour introduced into new version checking script ( #5016 )
2022-11-14 22:21:16 +00:00
Adam Warner
ba74051502
Grab local FTL hash correctly from FTL's own version output, and grab one digit less for remote hashes (also in debug log)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2022-11-14 22:09:26 +00:00
Adam Warner
cdbe4c9b86
Get only the precise tag number when getting local version, do not show branch name when on master branch(es)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2022-11-14 20:39:34 +00:00
Adam Warner
ca04c13315
sync: master to development ( #5013 )
2022-11-14 19:03:11 +00:00
Adam Warner
3c86af0e59
Pi-hole core v5.14 ( #5012 )
2022-11-14 19:00:40 +00:00
Adam Warner
ddaa1bf0d4
Correctly identify process status in debug script on docker ( #5011 )
2022-11-14 18:15:57 +00:00
Adam Warner
6b8ba3c15e
Replace deprecated shell commands ( #4907 )
2022-11-14 17:52:31 +00:00
Christian König
7536c312ee
Correctly identify process status in debug script on docker
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-13 21:53:59 +01:00
Adam Warner
a8b6eb9b70
Touch files before addKey or addOrEditKeyValPair ( #4999 )
2022-11-09 23:37:30 +00:00
Christian König
67385b7ed4
Touch files before addKey or addOrEditKeyValPair
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-09 21:25:09 +01:00
Adam Warner
64e61aac4a
Simplify versions.sh ( #4959 )
2022-11-09 17:15:51 +00:00
Christian König
2fd5b944ad
Touch setupVars before writing to it
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-11-03 22:09:12 +01:00
Dan Schaper
f91606bb17
Fix static IP not set because of in-line comment in dhcpcd.conf ( #4998 )
2022-11-02 15:17:36 -07:00
Stephan Pillhofer
122bc6b927
Fix static IP not set because of in-line comment
...
Signed-off-by: Stephan Pillhofer <43667664+StephanPillhofer@users.noreply.github.com>
2022-11-02 22:35:39 +01:00
Dan Schaper
3491dbfd04
Check versions
file on the debug log ( #4977 )
2022-10-31 13:25:15 -07:00
Dan Schaper
871067acd8
Fix static IP not set if IP is already present in any way inside dhcpcd.conf ( #4995 )
...
Use grep and regex to find uncommented use of `static ip_address` with IP.
2022-10-31 13:23:35 -07:00
Stephan Pillhofer
06cf7afbc2
Fix static IP not set
...
Signed-off-by: Stephan Pillhofer <43667664+StephanPillhofer@users.noreply.github.com>
2022-10-30 20:19:38 +01:00
MichaIng
81927334f2
Add native systemd service
...
Inspired by: https://github.com/pi-hole/pi-hole/pull/2112
A pre-start and a post-stop script are added to reduce doubled setup and cleanup code.
Since systemd services do not natively support dynamic users, test once whether capabilities are supported during install/update, and remove User=pihole otherwise.
Signed-off-by: MichaIng <micha@dietpi.com>
Co-authored-by: DL6ER <dl6er@dl6er.de>
2022-10-30 19:40:33 +01:00
yubiuser
01bf9ca42a
Prevent CNAME loop ( #4988 )
2022-10-29 15:44:03 +02:00
Christian König
c8c6533440
Add small explanation.
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-10-29 15:09:14 +02:00
Dan Schaper
f1b15f7e92
Remove check for latest component version in debug log ( #4973 )
2022-10-28 17:27:05 -07:00