Added unattended installation, fixed some variables

auto_install/install.sh

@@ -20,8 +20,10 @@ PKG_CACHE="/var/lib/apt/lists/"
 UPDATE_PKG_CACHE="${PKG_MANAGER} update"
 PKG_INSTALL="${PKG_MANAGER} --yes --no-install-recommends install"
 PKG_COUNT="${PKG_MANAGER} -s -o Debug::NoLocking=true upgrade | grep -c ^Inst || true"
+
 # Dependencies that are required by the script, regardless of the VPN protocol chosen
 BASE_DEPS=(git tar wget grep iptables-persistent dnsutils whiptail net-tools dhcpcd5)
+
 # Dependencies that where actually installed by the script. For example if the script requires
 # grep and dnsutils but dnsutils is already installed, we save grep here. This way when uninstalling
 # PiVPN we won't prompt to remove packages that may have been installed by the user for other reasons
@@ -43,6 +45,8 @@ screen_size=$(stty size 2>/dev/null || echo 24 80)
 rows=$(echo $screen_size | awk '{print $1}')
 columns=$(echo $screen_size | awk '{print $2}')
 
+runUnattended=false
+
 # Divide by two so the dialogs take up half of the screen, which looks nice.
 r=$(( rows / 2 ))
 c=$(( columns / 2 ))
@@ -51,7 +55,6 @@ r=$(( r < 20 ? 20 : r ))
 c=$(( c < 70 ? 70 : c ))
 
 # Find IP used to route to outside world
-IPv4dev=$(ip route get 8.8.8.8 | awk '{for(i=1;i<=NF;i++)if($i~/dev/)print $(i+1)}')
 IPv4addr=$(ip route get 8.8.8.8| awk '{print $7}')
 IPv4gw=$(ip route get 8.8.8.8 | awk '{print $3}')
 
@@ -60,13 +63,26 @@ dhcpcdFile=/etc/dhcpcd.conf
 
 # Next see if we are on a tested and supported OS
 noOSSupport(){
+	if [ "${runUnattended}" = 'true' ]; then
+		echo "::: Invalid OS detected"
+		echo "::: We have not been able to detect a supported OS."
+		echo "::: Currently this installer supports Raspbian (Buster) and Debian (Buster)."
+		exit 1
+	fi
+
 	whiptail --msgbox --backtitle "INVALID OS DETECTED" --title "Invalid OS" "We have not been able to detect a supported OS.
-Currently this installer supports Raspbian (Buster).
+Currently this installer supports Raspbian (Buster) and Debian (Buster).
 If you think you received this message in error, you can post an issue on the GitHub at https://github.com/pivpn/pivpn/issues." ${r} ${c}
 	exit 1
 }
 
 maybeOSSupport(){
+	if [ "${runUnattended}" = 'true' ]; then
+		echo "::: Not Supported OS"
+		echo "::: You are on an OS that we have not tested but MAY work, continuing anyway..."
+		return
+	fi
+
 	if (whiptail --backtitle "Not Supported OS" --title "Not Supported OS" --yesno "You are on an OS that we have not tested but MAY work.
 Currently this installer supports Raspbian (Buster).
 Would you like to continue anyway?" ${r} ${c}) then
@@ -118,6 +134,12 @@ checkHostname(){
 ###Checks for hostname size
 	host_name=$(hostname -s)
 	if [[ ! ${#host_name} -le 28 ]]; then
+		if [ "${runUnattended}" = 'true' ]; then
+			echo "::: Your hostname is too long."
+			echo "::: Use 'hostnamectl set-hostname YOURHOSTNAME' to set a new hostname"
+			echo "::: It must be less then 28 characters long and it must not use special characters"
+			exit 1
+		fi
 		until [[ ${#host_name} -le 28 && $host_name  =~ ^[a-zA-Z0-9][a-zA-Z0-9-]{1,28}$ ]]; do
 			host_name=$(whiptail --inputbox "Your hostname is too long.\nEnter new hostname with less then 28 characters\nNo special characters allowed." \
 		   --title "Hostname too long" ${r} ${c} 3>&1 1>&2 2>&3)
@@ -156,6 +178,9 @@ verifyFreeDiskSpace(){
 	if ! [[ "${existing_free_kilobytes}" =~ ^([0-9])+$ ]]; then
 		echo "::: Unknown free disk space!"
 		echo "::: We were unable to determine available free disk space on this system."
+		if [ "${runUnattended}" = 'true' ]; then
+			exit 1
+		fi
 		echo "::: You may continue with the installation, however, it is not recommended."
 		read -r -p "::: If you are sure you want to continue, type YES and press enter :: " response
 		case $response in
@@ -255,6 +280,13 @@ installDependentPackages(){
 }
 
 welcomeDialogs(){
+	if [ "${runUnattended}" = 'true' ]; then
+		echo "::: PiVPN Automated Installer"
+		echo "::: This installer will transform your Raspberry Pi into an OpenVPN or WireGuard server!"
+		echo "::: Initiating network interface"
+		return
+	fi
+
 	# Display the welcome dialog
 	whiptail --msgbox --backtitle "Welcome" --title "PiVPN Automated Installer" "This installer will transform your Raspberry Pi into an OpenVPN or WireGuard server!" ${r} ${c}
 
@@ -265,6 +297,27 @@ In the next section, you can choose to use your current network settings (DHCP)
 }
 
 chooseInterface(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$IPv4dev" ]; then
+			if [ "$(echo "${availableInterfaces}" | wc -l)" -eq 1 ]; then
+				IPv4dev="${availableInterfaces}"
+				echo "::: No interface specified, but only ${IPv4dev} is available, using it"
+			else
+				echo "::: No interface specified"
+				exit 1
+			fi
+		else
+			if ip -o link | grep -qw "${IPv4dev}"; then
+				echo "::: Using interface: ${IPv4dev}"
+			else
+				echo "::: Interface ${IPv4dev} does not exist"
+				exit 1
+			fi
+		fi
+		echo "IPv4dev=${IPv4dev}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	# Turn the available interfaces into an array so it can be used with a whiptail dialog
 	local interfacesArray=()
 	# Number of available interfaces
@@ -308,15 +361,82 @@ chooseInterface(){
 }
 
 avoidStaticIPv4Ubuntu() {
+	if [ "${runUnattended}" = 'true' ]; then
+		echo "::: Since we think you are not using Raspbian, we will not configure a static IP for you."
+		return
+	fi
+
 	# If we are in Ubuntu then they need to have previously set their network, so just use what you have.
 	whiptail --msgbox --backtitle "IP Information" --title "IP Information" "Since we think you are not using Raspbian, we will not configure a static IP for you.
 If you are in Amazon then you can not configure a static IP anyway. Just ensure before this installer started you had set an elastic IP on your instance." ${r} ${c}
+
+}
+
+validIP(){
+	local ip=$1
+	local stat=1
+
+	if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
+		OIFS=$IFS
+		IFS='.'
+		ip=($ip)
+		IFS=$OIFS
+		[[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
+		&& ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
+		stat=$?
+	fi
+	return $stat
 }
 
 getStaticIPv4Settings() {
-	local ipSettingsCorrect
 	# Grab their current DNS Server
-	IPv4dns=$(nslookup 127.0.0.1 | grep Server: | awk '{print $2}')
+	IPv4dns=$(grep nameserver /etc/resolv.conf | awk '{print $2}' | xargs)
+
+	if [ "${runUnattended}" = 'true' ]; then
+
+		local INVALID_STATIC_IPV4_SETTINGS=0
+
+		if [ -z "$IPv4addr" ]; then
+			echo "::: Missing static IP address"
+			INVALID_STATIC_IPV4_SETTINGS=1
+		fi
+
+		if [ -z "$IPv4gw" ]; then
+			echo "::: Missing static IP gateway"
+			INVALID_STATIC_IPV4_SETTINGS=1
+		fi
+
+		if [ "$INVALID_STATIC_IPV4_SETTINGS" -eq 1 ]; then
+			echo "::: Incomplete static IP settings"
+			exit 1
+		fi
+
+		if [ -z "$IPv4addr" ] && [ -z "$IPv4gw" ]; then
+			echo "::: No static IP settings, using current settings"
+			echo "::: Your static IPv4 address:    ${IPv4addr}"
+			echo "::: Your static IPv4 gateway:    ${IPv4gw}"
+		else
+			if validIP "${IPv4addr%/*}"; then
+				echo "::: Your static IPv4 address:    ${IPv4addr}"
+			else
+				echo "::: ${IPv4addr%/*} is not a valid IP address"
+				exit 1
+			fi
+
+			if validIP "${IPv4gw}"; then
+				echo "::: Your static IPv4 gateway:    ${IPv4gw}"
+			else
+				echo "::: ${IPv4gw} is not a valid IP address"
+				exit 1
+			fi
+		fi
+
+		echo "IPv4addr=${IPv4addr%/*}" >> /tmp/setupVars.conf
+		echo "IPv4gw=${IPv4gw}" >> /tmp/setupVars.conf
+		return
+	fi
+
+	local ipSettingsCorrect
 	# Ask if the user wants to use DHCP settings as their static IP
 	if (whiptail --backtitle "Calibrating network interface" --title "Static IP Address" --yesno "Do you want to use your current network settings as a static address?
 					IP address:    ${IPv4addr}
@@ -399,6 +519,30 @@ setStaticIPv4(){
 }
 
 chooseUser(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$install_user" ]; then
+			if [ "$(awk -F':' 'BEGIN {count=0} $3>=1000 && $3<=60000 { count++ } END{ print count }' /etc/passwd)" -eq 1 ]; then
+				install_user="$(awk -F':' '$3>=1000 && $3<=60000 {print $1}' /etc/passwd)"
+				echo "::: No user specified, but only ${install_user} is available, using it"
+			else
+				echo "::: No user specified"
+				exit 1
+			fi
+		else
+			if awk -F':' '$3>=1000 && $3<=60000 {print $1}' /etc/passwd | grep -qw "${install_user}"; then
+				echo "::: ${install_user} will hold your ovpn configurations."
+			else
+				echo "::: User ${install_user} does not exist"
+				exit 1
+			fi
+		fi
+		install_home=$(grep -m1 "^${install_user}:" /etc/passwd | cut -d: -f6)
+		install_home=${install_home%/}
+		echo "install_user=${install_user}" >> /tmp/setupVars.conf
+		echo "install_home=${install_home}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	# Explain the local user
 	whiptail --msgbox --backtitle "Parsing User List" --title "Local Users" "Choose a local user that will hold your ovpn configurations." ${r} ${c}
 	# First, let's check if there is a user available.
@@ -519,16 +663,37 @@ cloneOrUpdateRepos(){
 }
 
 askWhichVPN(){
-	if (whiptail --backtitle "Setup PiVPN" --title "Installation mode" --yesno "WireGuard is a new kind of VPN that provides near-istantaneous connection speed, high performance, modern cryptography.\n\nIt's the recommended choise expecially if you use mobile devices where WireGuard is easier on battery than OpenVPN.\n\nOpenVPN is still available if you need the traditional, flexible, trusted VPN protocol. Or if you need features like TCP and custom search domain.\n\nChoose 'Yes' to use WireGuard of 'No' to use OpenVPN." ${r} ${c});
+	if [ "${runUnattended}" = 'true' ]; then
-	then
+		if [ -z "$VPN" ]; then
-		VPN="WireGuard"
+			echo ":: No VPN protocol specified, using WireGuard"
+			VPN="wireguard"
+		else
+			VPN="${VPN,,}"
+			if [ "$VPN" = "wireguard" ]; then
+				echo "::: WireGuard will be installed"
+			elif [ "$VPN" = "openvpn" ]; then
+				echo "::: OpenVPN will be installed"
+			else
+				echo ":: $VPN is not a supported VPN protocol, please specify 'wireguard' or 'openvpn'"
+				exit 1
+			fi
+		fi
+	else
+		if (whiptail --backtitle "Setup PiVPN" --title "Installation mode" --yesno "WireGuard is a new kind of VPN that provides near-istantaneous connection speed, high performance, modern cryptography.\n\nIt's the recommended choise expecially if you use mobile devices where WireGuard is easier on battery than OpenVPN.\n\nOpenVPN is still available if you need the traditional, flexible, trusted VPN protocol. Or if you need features like TCP and custom search domain.\n\nChoose 'Yes' to use WireGuard of 'No' to use OpenVPN." ${r} ${c});
+		then
+			VPN="wireguard"
+		else
+			VPN="openvpn"
+		fi
+	fi
+
+	if [ "$VPN" = "wireguard" ]; then
 		pivpnPROTO="udp"
 		pivpnDEV="wg0"
-		pivpnNET="10.6.0.0/24"
+		pivpnNET="10.6.0.0"
-	else
+	elif [ "$VPN" = "openvpn" ]; then
-		VPN="OpenVPN"
 		pivpnDEV="tun0"
-		pivpnNET="10.8.0.0/24"
+		pivpnNET="10.8.0.0"
 	fi
 
 	echo "VPN=${VPN}" >> /tmp/setupVars.conf
@@ -654,42 +819,32 @@ Pin-Priority: 90" | $SUDO tee /etc/apt/preferences.d/limit-unstable > /dev/null
 	fi
 }
 
-validIP(){
-	local ip=$1
-	local stat=1
-
-	if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
-		OIFS=$IFS
-		IFS='.'
-		ip=($ip)
-		IFS=$OIFS
-		[[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
-		&& ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
-		stat=$?
-	fi
-	return $stat
-}
-
-#Call this function to use a regex to check user input for a valid custom domain
-validDomain(){
-	local domain=$1
-	local stat=1
-
-	if [[ $domain =~ ^[a-zA-Z0-9][a-zA-Z0-9-]{1,61}\.[a-zA-Z]{2,}$ ]]; then
-		stat=$?
-	fi
-  return $stat
-}
-
 askCustomProto(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$pivpnPROTO" ]; then
+			echo "::: No TCP/IP protocol specified, using the default protocol udp"
+			pivpnPROTO="udp"
+		else
+			pivpnPROTO="${pivpnPROTO,,}"
+			if [ "$pivpnPROTO" = "udp" ] || [ "$pivpnPROTO" = "tcp" ]; then
+				echo "::: Using the $pivpnPROTO protocol"
+			else
+				echo ":: $pivpnPROTO is not a supported TCP/IP protocol, please specify 'udp' or 'tcp'"
+				exit 1
+			fi
+		fi
+		echo "pivpnPROTO=${pivpnPROTO}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	# Set the available protocols into an array so it can be used with a whiptail dialog
-	if protocol=$(whiptail --title "Protocol" --radiolist \
+	if pivpnPROTO=$(whiptail --title "Protocol" --radiolist \
 		"Choose a protocol (press space to select). Please only choose TCP if you know why you need TCP." ${r} ${c} 2 \
 		"UDP" "" ON \
 		"TCP" "" OFF 3>&1 1>&2 2>&3)
 	then
 		# Convert option into lowercase (UDP->udp)
-		pivpnPROTO="${protocol,,}"
+		pivpnPROTO="${pivpnPROTO,,}"
 		echo "::: Using protocol: $pivpnPROTO"
 		echo "pivpnPROTO=${pivpnPROTO}" >> /tmp/setupVars.conf
 	else
@@ -699,13 +854,39 @@ askCustomProto(){
 }
 
 askCustomPort(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$pivpnPORT" ]; then
+			if [ "$VPN" = "wireguard" ]; then
+				echo "::: No port specified, using the default port 51820"
+				pivpnPORT=51820
+			elif [ "$VPN" = "openvpn" ]; then
+				if [ "$pivpnPROTO" = "udp" ]; then
+					echo "::: No port specified, using the default port 1194"
+					pivpnPORT=1194
+				elif [ "$pivpnPROTO" = "tcp" ]; then
+					echo "::: No port specified, using the default port 443"
+					pivpnPORT=443
+				fi
+			fi
+		else
+			if [[ "$pivpnPORT" =~ ^[0-9]+$ ]] && [ "$pivpnPORT" -ge 1 ] && [ "$pivpnPORT" -le 65535 ]; then
+				echo "::: Using port $pivpnPORT"
+			else
+				echo "::: $pivpnPORT is not a valid port, use a port within the range [1,65535] (inclusive)"
+				exit 1
+			fi
+		fi
+		echo "pivpnPORT=${pivpnPORT}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	until [[ $PORTNumCorrect = True ]]
 		do
 			portInvalid="Invalid"
 
-			if [ "$VPN" = "WireGuard" ]; then
+			if [ "$VPN" = "wireguard" ]; then
 				DEFAULT_PORT=51820
-			elif [ "$VPN" = "OpenVPN" ]; then
+			elif [ "$VPN" = "openvpn" ]; then
 				if [ "$pivpnPROTO" = "udp" ]; then
 					DEFAULT_PORT=1194
 				else
@@ -742,20 +923,48 @@ askCustomPort(){
 }
 
 askClientDNS(){
+	if [ "${runUnattended}" = 'true' ]; then
+
+		if [ -z "$pivpnDNS1" ] && [ -n "$pivpnDNS2" ]; then
+			pivpnDNS1="$pivpnDNS2"
+			unset pivpnDNS2
+		elif [ -z "$pivpnDNS1" ] && [ -z "$pivpnDNS2" ]; then
+			pivpnDNS1="8.8.8.8"
+			pivpnDNS2="8.8.4.4"
+			echo "::: No DNS provider specified, using Google DNS ($pivpnDNS1 $pivpnDNS2)"
+		fi
+
+		local INVALID_DNS_SETTINGS=0
+
+		if ! validIP "$pivpnDNS1"; then
+			INVALID_DNS_SETTINGS=1
+			echo "::: Invalid DNS $pivpnDNS1"
+		fi
+
+		if [ -n "$pivpnDNS2" ] && ! validIP "$pivpnDNS2"; then
+			INVALID_DNS_SETTINGS=1
+			echo "::: Invalid DNS $pivpnDNS2"
+		fi
+
+		if [ "$INVALID_DNS_SETTINGS" -eq 0 ]; then
+			echo "::: Using DNS $pivpnDNS1 $pivpnDNS2"
+		else
+			exit 1
+		fi
+
+		echo "pivpnDNS1=${pivpnDNS1}" >> /tmp/setupVars.conf
+		echo "pivpnDNS2=${pivpnDNS2}" >> /tmp/setupVars.conf
+		return
+	fi
 
 	# Detect and offer to use Pi-hole
 	if command -v pihole &>/dev/null; then
 		if (whiptail --backtitle "Setup PiVPN" --title "Pi-hole" --yesno "We have detected a Pi-hole installation, do you want to use it as the DNS server for the VPN, so you get ad blocking on the go?" ${r} ${c}); then
-			if [ "$VPN" = "WireGuard" ]; then
-				pivpnDEV="wg0"
-			elif [ "$VPN" = "OpenVPN" ]; then
-				pivpnDEV="tun0"
-			fi
-
 			pivpnDNS1="$IPv4addr"
-			echo "interface=$pivpnDNS" | $SUDO tee /etc/dnsmasq.d/02-pivpn.conf > /dev/null
+			echo "interface=$pivpnDEV" | $SUDO tee /etc/dnsmasq.d/02-pivpn.conf > /dev/null
 			$SUDO pihole restartdns
 			echo "pivpnDNS1=${pivpnDNS1}" >> /tmp/setupVars.conf
+			echo "pivpnDNS2=${pivpnDNS2}" >> /tmp/setupVars.conf
 			return
 		fi
 	fi
@@ -836,8 +1045,34 @@ askClientDNS(){
 	echo "pivpnDNS2=${pivpnDNS2}" >> /tmp/setupVars.conf
 }
 
+#Call this function to use a regex to check user input for a valid custom domain
+validDomain(){
+  local domain=$1
+  local stat=1
+
+  if [[ $domain =~ ^(([a-zA-Z0-9]{1,63}|([a-zA-Z0-9]{1,60}[-a-zA-Z0-9()]{0,2}[a-zA-Z0-9]{1,60}))\.){1,6}([a-zA-Z]{2,})$ ]]; then
+    stat=$?
+  fi
+  return $stat
+}
+
 #This procedure allows a user to specify a custom search domain if they have one.
 askCustomDomain(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -n "$pivpnDOMAIN" ]; then
+			if validDomain "$pivpnDOMAIN"; then
+				echo "::: Using custom domain $pivpnDOMAIN"
+			else
+				echo "::: Custom domain $pivpnDOMAIN is not valid"
+				exit 1
+			fi
+		else
+			echo "::: Skipping custom domain"
+		fi
+		echo "pivpnDOMAIN=${pivpnDOMAIN}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	DomainSettingsCorrect=False
 
 	if (whiptail --backtitle "Custom Search Domain" --title "Custom Search Domain" --yesno "Would you like to add a custom search domain? \n (This is only for advanced users who have their own domain)\n" ${r} ${c}); then
@@ -848,7 +1083,6 @@ askCustomDomain(){
 				if validDomain "$pivpnDOMAIN"; then
 					if (whiptail --backtitle "Custom Search Domain" --title "Custom Search Domain" --yesno "Are these settings correct?\n    Custom Search Domain: $pivpnDOMAIN" ${r} ${c}); then
 						DomainSettingsCorrect=True
-						echo "pivpnDOMAIN=${pivpnDOMAIN}" >> /tmp/setupVars.conf
 					else
 						# If the settings are wrong, the loop continues
 						DomainSettingsCorrect=False
@@ -862,10 +1096,9 @@ askCustomDomain(){
 				exit 1
 			fi
 		done
-
-	else
-		echo sleep 0.1
 	fi
+
+	echo "pivpnDOMAIN=${pivpnDOMAIN}" >> /tmp/setupVars.conf
 }
 
 askPublicIPOrDNS(){
@@ -877,6 +1110,24 @@ askPublicIPOrDNS(){
 		fi
 	fi
 
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$pivpnHOST" ]; then
+			echo "::: No IP or domain name specified, using public IP $IPv4pub"
+			pivpnHOST="$IPv4pub"
+		else
+			if validIP "$pivpnHOST"; then
+				echo "::: Using public IP $pivpnHOST"
+			elif validDomain "$pivpnHOST"; then
+				echo "::: Using domain name $pivpnHOST"
+			else
+				echo "::: $pivpnHOST is not a valid IP or domain name"
+				exit 1
+			fi
+		fi
+		echo "pivpnHOST=${pivpnHOST}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	METH=$(whiptail --title "Public IP or DNS" --radiolist "Will clients use a Public IP or DNS Name to connect to your server (press space to select)?" ${r} ${c} 2 \
 		"$IPv4pub" "Use this public IP" "ON" \
 		"DNS Entry" "Use a public DNS" "OFF" 3>&1 1>&2 2>&3)
@@ -911,6 +1162,28 @@ askPublicIPOrDNS(){
 }
 
 askEncryption(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$pivpnENCRYPT" ]; then
+			pivpnENCRYPT=2048
+			echo "::: Using a 2048 bit certificate"
+		else
+			if [ "$pivpnENCRYPT" -eq 2048 ] || [ "$pivpnENCRYPT" -eq 3072 ] || [ "$pivpnENCRYPT" -eq 4096 ]; then
+				echo "::: Using a ${pivpnENCRYPT}-bit certificate"
+			else
+				echo "::: ${pivpnENCRYPT} is not a valid certificate size, use 2048, 3072, or 4096"
+				exit 1
+			fi
+		fi
+
+		if [ -n "$DOWNLOAD_DH_PARAM" ]; then
+			echo "::: DH parameters will be downloaded from \"2 Ton Digital\""
+		fi
+
+		echo "pivpnENCRYPT=${pivpnENCRYPT}" >> /tmp/setupVars.conf
+		echo "DOWNLOAD_DH_PARAM=${DOWNLOAD_DH_PARAM}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	pivpnENCRYPT=$(whiptail --backtitle "Setup OpenVPN" --title "RSA certificate size" --radiolist \
 		"Choose the desired size of your certificate (press space to select):\nThis is a certificate that will be generated on your system. The larger the certificate, the more time this will take. For most applications, it is recommended to use 2048 bits. If you are paranoid about ... things... then grab a cup of joe and pick 4096 bits." ${r} ${c} 3 \
 			"2048" "Use a 2048-bit certificate (recommended level)" ON \
@@ -1020,6 +1293,10 @@ set_var EASYRSA_KEY_SIZE   ${pivpnENCRYPT}" | $SUDO tee vars >/dev/null
 		$SUDO sed -i "s/proto udp/proto tcp/g" /etc/openvpn/server.conf
 	fi
 
+	if [ -z "$pivpnDOMAIN" ]; then
+		$SUDO sed -i "0,/\(.*dhcp-option.*\)/s//\push \"dhcp-option DOMAIN ${pivpnDOMAIN}\" \n&/" /etc/openvpn/server.conf
+	fi
+
 	# write out server certs to conf file
 	$SUDO sed -i "s/\(key \/etc\/openvpn\/easy-rsa\/pki\/private\/\).*/\1${SERVER_NAME}.key/" /etc/openvpn/server.conf
 	$SUDO sed -i "s/\(cert \/etc\/openvpn\/easy-rsa\/pki\/issued\/\).*/\1${SERVER_NAME}.crt/" /etc/openvpn/server.conf
@@ -1058,7 +1335,10 @@ confWireGuard(){
 		$SUDO chmod 700 /etc/wireguard
 	fi
 
-	whiptail --title "Server Information" --msgbox "The Server Keys and Pre-Shared key will now be generated." "${r}" "${c}"
+	if [ "${runUnattended}" = 'false' ]; then
+		whiptail --title "Server Information" --msgbox "The Server Keys and Pre-Shared key will now be generated." "${r}" "${c}"
+		return
+	fi
 	$SUDO mkdir /etc/wireguard/configs
 	$SUDO touch /etc/wireguard/configs/clients.txt
 	$SUDO mkdir /etc/wireguard/keys
@@ -1091,10 +1371,10 @@ confNetwork(){
 			USING_UFW=1
 			echo "::: Detected UFW is enabled."
 			echo "::: Adding UFW rules..."
-			$SUDO sed "/delete these required/i *nat\n:POSTROUTING ACCEPT [0:0]\n-I POSTROUTING -s $pivpnNET -o $IPv4dev -j MASQUERADE\nCOMMIT\n" -i /etc/ufw/before.rules
+			$SUDO sed "/delete these required/i *nat\n:POSTROUTING ACCEPT [0:0]\n-I POSTROUTING -s ${pivpnNET}\/24 -o ${IPv4dev} -j MASQUERADE\nCOMMIT\n" -i /etc/ufw/before.rules
 			# Insert rules at the beginning of the chain (in case there are other rules that may drop the traffic)
-			$SUDO ufw insert 1 allow "$pivpnPORT"/"$pivpnPROTO" >/dev/null
+			$SUDO ufw insert 1 allow "${pivpnPORT}"/"${pivpnPROTO}" >/dev/null
-			$SUDO ufw route insert 1 allow in on "$pivpnDEV" from "$pivpnNET" out on "$IPv4dev" to any >/dev/null
+			$SUDO ufw route insert 1 allow in on "${pivpnDEV}" from "${pivpnNET}/24" out on "${IPv4dev}" to any >/dev/null
 
 			$SUDO ufw reload >/dev/null
 			echo "::: UFW configuration completed."
@@ -1107,7 +1387,7 @@ confNetwork(){
 		# Now some checks to detect which rules we need to add. On a newly installed system all policies
 		# should be ACCEPT, so the only required rule would be the MASQUERADE one.
 
-		$SUDO iptables -t nat -I POSTROUTING -s "$pivpnNET" -o "$IPv4dev" -j MASQUERADE
+		$SUDO iptables -t nat -I POSTROUTING -s "${pivpnNET}/24" -o "${IPv4dev}" -j MASQUERADE
 
 		# Count how many rules are in the INPUT and FORWARD chain. When parsing input from
 		# iptables -S, '^-P' skips the policies and 'ufw-' skips ufw chains (in case ufw was found
@@ -1126,15 +1406,15 @@ confNetwork(){
 		# chain (using -I).
 
 		if [ "$INPUT_RULES_COUNT" -ne 0 ] || [ "$INPUT_POLICY" != "ACCEPT" ]; then
-			$SUDO iptables -I INPUT 1 -i "$IPv4dev" -p "$pivpnPROTO" --dport "$pivpnPORT" -j ACCEPT
+			$SUDO iptables -I INPUT 1 -i "${IPv4dev}" -p "${pivpnPROTO}" --dport "${pivpnPORT}" -j ACCEPT
 			INPUT_CHAIN_EDITED=1
 		else
 			INPUT_CHAIN_EDITED=0
 		fi
 
 		if [ "$FORWARD_RULES_COUNT" -ne 0 ] || [ "$FORWARD_POLICY" != "ACCEPT" ]; then
-			$SUDO iptables -I FORWARD 1 -d "$pivpnNET" -i "$IPv4dev" -o "$pivpnDEV" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
+			$SUDO iptables -I FORWARD 1 -d "${pivpnNET}/24" -i "${IPv4dev}" -o "${pivpnDEV}" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
-			$SUDO iptables -I FORWARD 2 -s "$pivpnNET" -i "$pivpnDEV" -o "$IPv4dev" -j ACCEPT
+			$SUDO iptables -I FORWARD 2 -s "${pivpnNET}/24" -i "${pivpnDEV}" -o "${IPv4dev}" -j ACCEPT
 			FORWARD_CHAIN_EDITED=1
 		else
 			FORWARD_CHAIN_EDITED=0
@@ -1183,7 +1463,7 @@ installPiVPN(){
 	$SUDO mkdir -p /etc/pivpn/
 	askWhichVPN
 
-	if [ "$VPN" = "OpenVPN" ]; then
+	if [ "$VPN" = "openvpn" ]; then
 		installOpenVPN
 		askCustomProto
 		askCustomPort
@@ -1195,7 +1475,7 @@ installPiVPN(){
 		confOVPN
 		confNetwork
 		confLogging
-	elif [ "$VPN" = "WireGuard" ]; then
+	elif [ "$VPN" = "wireguard" ]; then
 		installWireGuard
 		askCustomPort
 		askClientDNS
@@ -1206,12 +1486,25 @@ installPiVPN(){
 }
 
 askUnattendedUpgrades(){
+	if [ "${runUnattended}" = 'true' ]; then
+		if [ -z "$UNATTUPG" ]; then
+			UNATTUPG=1
+			echo "::: No preference regarding unattended upgrades, assuming yes"
+		else
+			if [ "$UNATTUPG" -eq 1 ]; then
+				echo "::: Enabling unattended upgrades"
+			else
+				echo "::: Skipping unattended upgrades"
+			fi
+		fi
+		echo "UNATTUPG=${UNATTUPG}" >> /tmp/setupVars.conf
+		return
+	fi
+
 	whiptail --msgbox --backtitle "Security Updates" --title "Unattended Upgrades" "Since this server will have at least one port open to the internet, it is recommended you enable unattended-upgrades.\nThis feature will check daily for security package updates only and apply them when necessary.\nIt will NOT automatically reboot the server so to fully apply some updates you should periodically reboot." ${r} ${c}
 
 	if (whiptail --backtitle "Security Updates" --title "Unattended Upgrades" --yesno "Do you want to enable unattended upgrades of security patches to this server?" ${r} ${c}); then
 		UNATTUPG=1
-		PIVPN_DEPS=(unattended-upgrades)
-		installDependentPackages PIVPN_DEPS[@]
 	else
 		UNATTUPG=0
 	fi
@@ -1220,27 +1513,32 @@ askUnattendedUpgrades(){
 }
 
 confUnattendedUpgrades(){
-	cd /etc/apt/apt.conf.d
+	if [ "$UNATTUPG" -eq 1 ]; then
+		PIVPN_DEPS=(unattended-upgrades)
+		installDependentPackages PIVPN_DEPS[@]
 
-	if [ "$PLAT" = "Raspbian" ]; then
+		cd /etc/apt/apt.conf.d
-		wget -qO- "$UNATTUPG_CONFIG" | $SUDO tar xz
+
-		$SUDO cp "unattended-upgrades-$UNATTUPG_RELEASE/data/50unattended-upgrades.Raspbian" 50unattended-upgrades
+		if [ "$PLAT" = "Raspbian" ]; then
-		$SUDO rm -rf "unattended-upgrades-$UNATTUPG_RELEASE"
+			wget -qO- "$UNATTUPG_CONFIG" | $SUDO tar xz
+			$SUDO cp "unattended-upgrades-$UNATTUPG_RELEASE/data/50unattended-upgrades.Raspbian" 50unattended-upgrades
+			$SUDO rm -rf "unattended-upgrades-$UNATTUPG_RELEASE"
+		fi
+
+		# On architectures different from armv6l, where we install wireguard from source, enable
+		# automatic updates via the unstable repository
+		if [ "$VPN" = "wireguard" ] && [ "$(uname -m)" != "armv6l" ]; then
+			$SUDO sed -i '/Unattended-Upgrade::Origins-Pattern {/a"o=Debian,a=unstable";' 50unattended-upgrades
+		fi
+
+		# Add the remaining settings for all other distributions
+		echo "APT::Periodic::Enable \"1\";
+		APT::Periodic::Update-Package-Lists \"1\";
+		APT::Periodic::Download-Upgradeable-Packages \"1\";
+		APT::Periodic::Unattended-Upgrade \"1\";
+		APT::Periodic::AutocleanInterval \"7\";
+		APT::Periodic::Verbose \"0\";" | $SUDO tee 02periodic > /dev/null
 	fi
-
-	# On architectures different from armv6l, where we install wireguard from source, enable
-	# automatic updates via the unstable repository
-	if [ "$VPN" = "WireGuard" ] && [ "$(uname -m)" != "armv6l" ]; then
-		$SUDO sed -i '/Unattended-Upgrade::Origins-Pattern {/a"o=Debian,a=unstable";' 50unattended-upgrades
-	fi
-
-	# Add the remaining settings for all other distributions
-	echo "APT::Periodic::Enable \"1\";
-	APT::Periodic::Update-Package-Lists \"1\";
-	APT::Periodic::Download-Upgradeable-Packages \"1\";
-	APT::Periodic::Unattended-Upgrade \"1\";
-	APT::Periodic::AutocleanInterval \"7\";
-	APT::Periodic::Verbose \"0\";" | $SUDO tee 02periodic > /dev/null
 }
 
 installScripts(){
@@ -1253,18 +1551,26 @@ installScripts(){
 		$SUDO chmod 0755 /opt/pivpn
 	fi
 
-	FOLDER=$(tr '[:upper:]' '[:lower:]' <<< "$VPN")
 	$SUDO cp /etc/.pivpn/scripts/uninstall.sh /opt/pivpn/
-	$SUDO cp /etc/.pivpn/scripts/$FOLDER/*.sh /opt/pivpn/
+	$SUDO cp /etc/.pivpn/scripts/$VPN/*.sh /opt/pivpn/
 	$SUDO chmod 0755 /opt/pivpn/*.sh
-	$SUDO cp /etc/.pivpn/scripts/$FOLDER/pivpn /usr/local/bin/pivpn
+	$SUDO cp /etc/.pivpn/scripts/$VPN/pivpn /usr/local/bin/pivpn
 	$SUDO chmod 0755 /usr/local/bin/pivpn
-	$SUDO cp /etc/.pivpn/scripts/$FOLDER/bash-completion /etc/bash_completion.d/pivpn
+	$SUDO cp /etc/.pivpn/scripts/$VPN/bash-completion /etc/bash_completion.d/pivpn
 	. /etc/bash_completion.d/pivpn
 	echo " done."
 }
 
 displayFinalMessage(){
+	if [ "${runUnattended}" = 'true' ]; then
+		echo "::: Installation Complete!"
+		echo "::: Now run 'pivpn add' to create the ovpn profiles.
+Run 'pivpn help' to see what else you can do!\n\nIf you run into any issue, please read all our documentation carefully.
+All incomplete posts or bug reports will be ignored or deleted.\n\nThank you for using PiVPN."
+		echo "::: It is strongly recommended you reboot after installation."
+		return
+	fi
+
 	# Final completion message to user
 	whiptail --msgbox --backtitle "Make it so." --title "Installation Complete!" "Now run 'pivpn add' to create the ovpn profiles.
 Run 'pivpn help' to see what else you can do!\n\nIf you run into any issue, please read all our documentation carefully.
@@ -1299,12 +1605,6 @@ main(){
 		fi
 	fi
 
-	# Check for supported distribution
-	distroCheck
-
-	# Checks for hostname Length
-	checkHostname
-
 	# Check arguments for the undocumented flags
 	for var in "$@"; do
 		case "$var" in
@@ -1313,8 +1613,19 @@ main(){
 		esac
 	done
 
+	# Check for supported distribution
+	distroCheck
+
+	# Checks for hostname Length
+	checkHostname
+
 	if [[ "${runUnattended}" == true ]]; then
 		echo "::: --unattended passed to install script, no whiptail dialogs will be displayed"
+		if [ -r "$1" ]; then
+			source "$1"
+		else
+			echo "::: Warning: can't open $1, using default settings..."
+		fi
 	fi
 
 	# Start the installer
@@ -1364,10 +1675,10 @@ main(){
 	# Start services
 	case ${PLAT} in
 		Debian|Raspbian)
-			if [ "$VPN" = "OpenVPN" ]; then
+			if [ "$VPN" = "openvpn" ]; then
 				$SUDO systemctl enable openvpn.service
 				$SUDO systemctl start openvpn.service
-			elif [ "$VPN" = "WireGuard" ]; then
+			elif [ "$VPN" = "wireguard" ]; then
 				$SUDO systemctl enable wg-quick@wg0.service
 				$SUDO systemctl start wg-quick@wg0.service
 			fi
@@ -1389,12 +1700,6 @@ main(){
 	echo "::: done."
 
 	displayFinalMessage
-
-	echo ":::"
-	echo "::: Installation Complete!"
-	echo "::: Now run 'pivpn add' to create an ovpn profile for each of your devices."
-	echo "::: Run 'pivpn help' to see what else you can do!"
-	echo "::: It is strongly recommended you reboot after installation."
 	echo ":::"
 }
 

scripts/uninstall.sh

@@ -42,10 +42,10 @@ removeAll(){
 	# Stopping and disabling services
 	echo "::: Stopping and disabling services..."
 
-	if [ "$VPN" = "WireGuard" ]; then
+	if [ "$VPN" = "wireguard" ]; then
 		systemctl stop wg-quick@wg0
 		systemctl disable wg-quick@wg0 &> /dev/null
-	elif [ "$VPN" = "OpenVPN" ]; then
+	elif [ "$VPN" = "openvpn" ]; then
 		systemctl stop openvpn
 		systemctl disable openvpn &> /dev/null
 	fi
@@ -53,19 +53,19 @@ removeAll(){
 	# Removing firewall rules.
 	echo "::: Removing firewall rules..."
 
-	if [ "$VPN" = "WireGuard" ]; then
+	if [ "$VPN" = "wireguard" ]; then
-		pivpnDEV="wg0"
-		pivpnNET="10.6.0.0/24"
 		pivpnPROTO="udp"
-	elif [ "$VPN" = "OpenVPN" ]; then
+		pivpnDEV="wg0"
+		pivpnNET="10.6.0.0"
+	elif [ "$VPN" = "openvpn" ]; then
 		pivpnDEV="tun0"
-		pivpnNET="10.8.0.0/24"
+		pivpnNET="10.8.0.0"
 	fi
 
 	if [ "$USING_UFW" -eq 1 ]; then
 
 		ufw delete allow "${pivpnPORT}"/"${pivpnPROTO}" > /dev/null
-		ufw route delete allow in on "$pivpnDEV" from "$pivpnNET" out on "${IPv4dev}" to any > /dev/null
+		ufw route delete allow in on "${pivpnDEV}" from "${pivpnNET}/24" out on "${IPv4dev}" to any > /dev/null
 		sed -z "s/*nat\n:POSTROUTING ACCEPT \[0:0\]\n-I POSTROUTING -s ${pivpnNET}\/24 -o ${IPv4dev} -j MASQUERADE\nCOMMIT\n\n//" -i /etc/ufw/before.rules
 		ufw reload &> /dev/null
 
@@ -76,11 +76,11 @@ removeAll(){
 		fi
 
 		if [ "$FORWARD_CHAIN_EDITED" -eq 1 ]; then
-			iptables -D FORWARD -d "$pivpnNET" -i "${IPv4dev}" -o "$pivpnDEV" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
+			iptables -D FORWARD -d "${pivpnNET}/24" -i "${IPv4dev}" -o "${pivpnDEV}" -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
-			iptables -D FORWARD -s "$pivpnNET" -i "$pivpnDEV" -o "${IPv4dev}" -j ACCEPT
+			iptables -D FORWARD -s "${pivpnNET}/24" -i "${pivpnDEV}/24" -o "${IPv4dev}" -j ACCEPT
 		fi
 
-		iptables -t nat -D POSTROUTING -s "$pivpnNET" -o "${IPv4dev}" -j MASQUERADE
+		iptables -t nat -D POSTROUTING -s "${pivpnNET}/24" -o "${IPv4dev}" -j MASQUERADE
 		iptables-save > /etc/iptables/rules.v4
 
 	fi