Pi-hole/pivpn
Pi-hole/pivpn
1
0
Fork 0
mirror of https://github.com/pivpn/pivpn.git synced 2024-12-18 10:50:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

Shellcheck compliance

Browse source 
scripts/self_check.sh
  * Fixes SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
  * SC2154: <VarName> is referenced but not assigned.
  * Disabled warnings for the mentioned errors as they are sourced externaly and may vary
This commit is contained in:
4s3ti 2021-11-02 17:01:08 +01:00
parent 0de5656208
commit 8598013294
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scripts/self_check.sh
View file

@ -10,6 +10,8 @@ if [ ! -f "${setupVars}" ]; then
exit 1
fi
# SC1090 disabled as setupVars file differs from system to system
# shellcheck disable=SC1090
source "${setupVars}"
if [ "$VPN" = "wireguard" ]; then
@ -34,6 +36,8 @@ fi
if [ "$USING_UFW" -eq 0 ]; then
# Disabled SC Warnings for SC2154, values for variables are sourced from setupVars
# shellcheck disable=SC2154
if iptables -t nat -C POSTROUTING -s "${pivpnNET}/${subnetClass}" -o "${IPv4dev}" -j MASQUERADE -m comment --comment "${VPN}-nat-rule" &> /dev/null; then
echo ":: [OK] Iptables MASQUERADE rule set"
else
@ -48,6 +52,8 @@ if [ "$USING_UFW" -eq 0 ]; then
if [ "$INPUT_CHAIN_EDITED" -eq 1 ]; then
# Disabled SC Warnings for SC2154, values for variables are sourced from setupVars
# shellcheck disable=SC2154
if iptables -C INPUT -i "${IPv4dev}" -p "${pivpnPROTO}" --dport "${pivpnPORT}" -j ACCEPT -m comment --comment "${VPN}-input-rule" &> /dev/null; then
echo ":: [OK] Iptables INPUT rule set"
else
@ -63,6 +69,8 @@ if [ "$USING_UFW" -eq 0 ]; then
if [ "$FORWARD_CHAIN_EDITED" -eq 1 ]; then
# Disabled SC Warnings for SC2154, values for variables are sourced from setupVars
# shellcheck disable=SC2154
if iptables -C FORWARD -s "${pivpnNET}/${subnetClass}" -i "${pivpnDEV}" -o "${IPv4dev}" -j ACCEPT -m comment --comment "${VPN}-forward-rule" &> /dev/null; then
echo ":: [OK] Iptables FORWARD rule set"
else