Commit graph

71 commits

Author SHA1 Message Date
4s3ti
78810a5781 Shellcheck compliance
scripts/openvpn/removeOVPN.sh
  * SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
    * Disabled warning
  * SC2128: Expanding an array without an index only gives the first element.
    * Disabled warning, as its only checking if variable is empty
  * SC2001: See if you can use ${variable//search/replace} instead.
    * Disabled warning, regex doesn't apply to ${variable//search/replace}
  * SC2086: Double quote to prevent globbing and word splitting.
    * Added double quotes
  * SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?
    * Removed unecessary double quotes from %s
  * SC2154: <VariableName> is referenced but not assigned.
    * Disabled warning, variables sourced externally
2021-11-03 13:40:51 +01:00
4s3ti
0e313fa3b3 Shellcheck compliance
scripts/openvpn/pivpnDebug.sh
  * SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
    * Disabled warning message
  * SC2154: <VariableName> is referenced but not assigned.
    * Disabled warning message
  * SC2086: Double quote to prevent globbing and word splitting.
    * Added double quotes
  * SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
    * Added double quotes
2021-11-03 13:02:25 +01:00
4s3ti
e476cc11ee Shellcheck compliance
scripts/openvpn/makeOVPN.sh
 * SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
  * Disabled warning
 * SC2086: Double quote to prevent globbing and word splitting.
  * Added missing double quotes
 * SC2001: See if you can use ${variable//search/replace} instead.
  * Disabled warning, suggested method doesn't go well with regexp
 * SC2154: <VarName> is referenced but not assigned.
  * Disabled warning, variables are sourced externally and may differ
2021-11-03 12:21:51 +01:00
4s3ti
12de079a8c Shellcheck compliance
scripts/openvpn/clientStats.sh
  * fix SC2086: Double quote to prevent globbing and word splitting.
  * Added missing double quotes
2021-11-03 02:00:20 +01:00
4s3ti
4d2e3ed3f8 Shellcheck compliance
scripts/openvpn/bash-completion
 * fix SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
 * Added double quotes
2021-11-02 18:30:12 +01:00
Orazio
ba4ef93297 More compact commit log
- Do not show the full commit body
  - Show the branch
2021-05-12 18:17:35 +02:00
Orazio
88f6fca36e Changed link for the FAQ to https://docs.pivpn.io/faq 2021-05-11 15:22:52 +02:00
4s3ti
cd54260733
Merge pull request #1256 from DundarGoc/SC2027
Fixed shellcheck warning SC2027
2021-02-14 19:11:22 +01:00
Dundar Göc
ba1040f13e Fixed shellcheck warning SC2027:
SC2027: The surrounding quotes actually unquote this. Remove or escape them.
2021-02-14 15:31:44 +01:00
Dundar Göc
7438b49961 Fixed shellcheck issue SC2148
SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
2021-02-14 13:43:35 +01:00
Dundar Göc
8aa4607e5e Fixed shellcheck issue SC2015: Note that A && B || C is not if-then-else. C may run when A is true.
Replaced [ $1 -gt 1 ] && shift $1 || shift with shift $1 since
shift 1 is identical to shift.
2021-02-13 22:40:05 +01:00
Dundar Göc
513c2afc2e Fixed shellcheck warning SC2004, SC2006, SC2129, SC2219. Issue #1233.
SC2004: "$/${} is unnecessary on arithmetic variables."
SC2006: "Use $(...) notation instead of legacy backticked `...`."
SC2129: "Consider using { cmd1; cmd2; } >> file instead of individual redirects."
SC2219: "Instead of 'let expr', prefer (( expr ))."
2021-02-07 21:31:13 +01:00
glitch452
be692a8782 Pass along exit code when running a sub-script, instead of always running exit 0 2021-01-23 15:58:03 -05:00
Orazio
7f1c5ba33c Save debug to /tmp/debug.log for WireGuard too, do not use temporary file to redact IPs in the OpenVPN log. 2020-10-27 12:19:46 +01:00
Orazio
8b69904b69 Moved Telekom Hybrid help to the wiki:
-  https://github.com/pivpn/pivpn/wiki/OpenVPN#trouble-with-telekom-hybrid
2020-10-27 09:03:34 +01:00
Orazio
43057b3f3b Fixed typos, clarified 'pivpn -l' text. 2020-10-24 16:00:26 +02:00
Douglas Orend
22cb5ee0ef
Update removeOVPN.sh
This commit allows PiVPN scripts to revoke certificates with common names like "José" better. Prior to this commit, names like "José" could not be revoked using PiVPN tools.
2020-10-20 11:00:35 -05:00
Douglas Orend
5d2761b94b
Update listOVPN.sh
This commit allows PiVPN scripts to display certificates with common names like "José" better. Prior to this commit, names like "José" would be shown as "Jos\xC3\xA9".
2020-10-20 10:57:28 -05:00
Ludwig Lautenbacher
1cc66efba6 fixed formatting 2020-10-01 13:40:49 +02:00
Ludwig Lautenbacher
66536272be clean up formattting of Expired certificates 2020-10-01 13:24:02 +02:00
Ludwig Lautenbacher
0fb22bd15f dump easyrsa output to /dev/null 2020-10-01 13:23:31 +02:00
Ludwig Lautenbacher
5c26782925 Showing expired certificates as such. 2020-09-10 14:55:35 +02:00
Orazio
85478aaea0 Disallow integers as client names to avoid ambiguity when removing a client by index. 2020-07-23 14:50:59 +02:00
Orazio
4b239cfdc6
Merge pull request #1087 from gizmocuz/ft-index
Feature: Add Index based option for remove/qr commands
2020-07-23 10:44:15 +02:00
gi8
aa297e5296 add parameter to force remove profile 2020-07-16 15:01:27 +02:00
Rob Peters
960a084866 Better list presentation 2020-07-14 13:27:40 +02:00
GizMoCuz
e6b081e0f9 Added missing regex 2020-07-08 16:43:32 +02:00
GizMoCuz
c00e208286 Add Index for OpenVPN remover command 2020-07-08 16:36:23 +02:00
Orazio
b2ab7fc862 Fix change from pull request #1000 that prevented 'pivpn -l' to show revoked client names 2020-06-09 15:45:38 +02:00
Hìr0
e7df6752cd #281 CHANGED Minor changes after cross-check 2020-06-07 16:09:55 +02:00
Hìr0
46c463d1d5 Fix issue pivpn#281 2020-06-01 00:39:18 +02:00
Orazio
427c484cac Updated backup scripts for dual VPN 2020-05-29 17:46:04 +02:00
Orazio
823afa3fbb Improved dual VPN uninstallation, remove duplicate code/script
- Allow using 'pivpn vpn -u' to directly uninstall VPN 'vpn'
  - Also allow using 'pivpn -u' with two VPNs (will present a dialog).
  - During uninstall, ask which VPN to remove only if there are two VPNs
  - PiVPN git repo will be downloaded to '/usr/local/src/pivpn'. All scripts
    in /opt/pivpn, the main pivpn script and the bash completion file,
    are now just symbolic links. Resolves issue #695.
  - Remove unused call to updateWireGuard().
2020-05-27 16:36:26 +02:00
Orazio
1dc10e7d54
Merge pull request #1054 from shelleycat485/test
Tidy dual VPN protocol install
2020-05-26 09:55:22 +02:00
shelleycat485
15804dff39 selfcheck checks one VPN type again 2020-05-25 15:24:50 +01:00
Orazio
f06f6d7920 Temporarily disable 'pivpn -up' until a proper update strategy is defined
- 'pivpn -up' pulls the latest scripts from github, however, as of now, its usefulness
    is limited since usually a change in those scripts is a result of a change in the
    installation process, and those changes can't be applied to an older installation.
2020-05-25 10:14:15 +02:00
Orazio
2913f2701f Fix issue #1037 2020-05-23 11:08:51 +02:00
shelleycat485
b90077bd78 remove refs to /etc/pivpn/setupVars in selfcheck and debug scripts
tidy indenting
  on install, check if symlink already exists before making one to avoid error
  uninstall indicates which vpns are available for uninstall
  selfcheck checks both protocols if both present
  install - additional text in reconfigure saying 2nd protocol can be added
  change to use pivpn ovpn instaed of pivpn opv when dual protocols exist
2020-05-22 12:41:02 +01:00
shelleycat485
21d954167c typo in openvpn 2020-05-05 21:43:20 +01:00
shelleycat485
4e3a58702f more dual 2020-05-05 00:05:10 +01:00
root
f379ca2e10 initial dual install try 2020-04-28 23:44:56 +01:00
psgoundar
4039a0d173
Update scripts/openvpn/listOVPN.sh
Co-Authored-By: Orazio <orazioedoardo@users.noreply.github.com>
2020-04-05 14:35:33 -07:00
psgoundar
fb1cd97c28
Update scripts/openvpn/listOVPN.sh
Co-Authored-By: Orazio <orazioedoardo@users.noreply.github.com>
2020-04-05 14:34:53 -07:00
psgoundar
ec6880eb99
Apply suggestions from code review
Format Changes Reviewed.

Co-Authored-By: Orazio <orazioedoardo@users.noreply.github.com>
2020-04-01 19:44:37 -07:00
Swamy Goundar
289e85e306 Fixed issue with Name when OU is defined in CA 2020-03-28 20:48:44 -07:00
Swamy Goundar
c28448b94a Updated listOVPN to Include Expiration Dates 2020-03-28 19:36:55 -07:00
Orazio
6653d4caa3 Show connected clients data rates with dotted decimal notation 2020-03-13 12:03:41 +01:00
Orazio
9846d3787a Use variables to define VPN ranges instead of hard coding IPs 2020-02-16 09:09:09 +01:00
Orazio
0cb5546608 Get $STATIC_IP before ccd folder is deleted (otherwhise $STATIC_IP will be empty) 2020-02-10 17:36:39 +01:00
Orazio
2c6ba65288 Implemented feature request from issue #942 (OpenVPN) 2020-02-09 18:55:30 +01:00