Software-Mac/spacedrive
Software-Mac/spacedrive
1
0
Fork 0
mirror of https://github.com/spacedriveapp/spacedrive synced 2024-07-02 10:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Memoise useExplorerPreference props (#2363)

Browse source 
* memoise useExplorerPreference props

* this is even faster

---------

Co-authored-by: Utku Bakir <74243531+utkubakir@users.noreply.github.com>
This commit is contained in:
Brendan Allan 2024-04-19 11:30:39 +08:00 committed by GitHub
parent e4dd2b73ec
commit 1a438c630e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
interface/app/$libraryId/location/$id.tsx
View file

@ -1,5 +1,5 @@
import { ArrowClockwise, Info } from '@phosphor-icons/react';
import { useEffect, useMemo } from 'react';
import { useCallback, useEffect, useMemo } from 'react';
import { stringify } from 'uuid';
import {
arraysEqual,
@ -226,11 +226,17 @@ function getLastSectionOfPath(path: string): string | undefined {
function useLocationExplorerSettings(location: Location) {
const preferences = useExplorerPreferences({
data: location,
createDefaultSettings: () =>
createDefaultExplorerSettings<FilePathOrder>({
order: { field: 'name', value: 'Asc' }
}),
getSettings: (prefs) => prefs.location?.[stringify(location.pub_id)]?.explorer,
createDefaultSettings: useCallback(
() =>
createDefaultExplorerSettings<FilePathOrder>({
order: { field: 'name', value: 'Asc' }
}),
[]
),
getSettings: useCallback(
(prefs) => prefs.location?.[stringify(location.pub_id)]?.explorer,
[location.pub_id]
),
writeSettings: (settings) => ({
location: { [stringify(location.pub_id)]: { explorer: settings } }
})

12
interface/app/$libraryId/tag/$id.tsx
View file

@ -1,4 +1,4 @@
import { useMemo } from 'react';
import { useCallback, useMemo } from 'react';
import { ObjectOrder, Tag, useCache, useLibraryQuery, useNodes } from '@sd/client';
import { LocationIdParamsSchema } from '~/app/route-schemas';
import { Icon } from '~/components';
@ -91,8 +91,14 @@ export function Component() {
function useTagExplorerSettings(tag: Tag) {
const preferences = useExplorerPreferences({
data: tag,
createDefaultSettings: () => createDefaultExplorerSettings<ObjectOrder>({ order: null }),
getSettings: (prefs) => prefs.tag?.[stringify(tag.pub_id)]?.explorer,
createDefaultSettings: useCallback(
() => createDefaultExplorerSettings<ObjectOrder>({ order: null }),
[]
),
getSettings: useCallback(
(prefs) => prefs.tag?.[stringify(tag.pub_id)]?.explorer,
[tag.pub_id]
),
writeSettings: (settings) => ({
tag: { [stringify(tag.pub_id)]: { explorer: settings } }
})