Software-Mac/spacedrive
Software-Mac/spacedrive
1
0
Fork 0
mirror of https://github.com/spacedriveapp/spacedrive synced 2024-07-04 12:13:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ENG-1344] Limit node name length (#1730)

Browse source 
limit length
This commit is contained in:
Oscar Beaumont 2023-11-04 20:16:15 +11:00 committed by GitHub
parent bf543f45d0
commit 395e0ee3da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/api/nodes.rs
View file

@ -20,7 +20,7 @@ pub(crate) fn mount() -> AlphaRouter<Ctx> {
}
R.mutation(|node, args: ChangeNodeNameArgs| async move {
if let Some(name) = &args.name {
if name.is_empty() || name.len() > 32 {
if name.is_empty() || name.len() > 250 {
return Err(rspc::Error::new(
ErrorCode::BadRequest,
"invalid node name".into(),

19
core/src/node/config.rs
View file

@ -47,16 +47,19 @@ impl Migrate for NodeConfig {
type Ctx = ();
fn default(_path: PathBuf) -> Result<Self, MigratorError> {
let mut name = match hostname::get() {
// SAFETY: This is just for display purposes so it doesn't matter if it's lossy
Ok(hostname) => hostname.to_string_lossy().into_owned(),
Err(err) => {
eprintln!("Falling back to default node name as an error occurred getting your systems hostname: '{err}'");
"my-spacedrive".into()
}
};
name.truncate(250);
Ok(Self {
id: Uuid::new_v4(),
name: match hostname::get() {
// SAFETY: This is just for display purposes so it doesn't matter if it's lossy
Ok(hostname) => hostname.to_string_lossy().into_owned(),
Err(err) => {
eprintln!("Falling back to default node name as an error occurred getting your systems hostname: '{err}'");
"my-spacedrive".into()
}
},
name,
keypair: Keypair::generate(),
p2p: Default::default(),
features: vec![],

2
interface/app/$libraryId/settings/client/general.tsx
View file

@ -33,7 +33,7 @@ export const Component = () => {
const form = useZodForm({
schema: z.object({
name: z.string().min(1).optional(),
name: z.string().min(1).max(250).optional(),
p2p_enabled: z.boolean().optional(),
p2p_port: u16,
customOrDefault: z.enum(['Custom', 'Default'])