Software-Mac/spacedrive
Software-Mac/spacedrive
1
0
Fork 0
mirror of https://github.com/spacedriveapp/spacedrive synced 2024-07-14 06:34:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ENG-851] Fix explorer view context menu (#1054)

Browse source 
* Fix explorer view context menu

* Update to check for undefined
This commit is contained in:
nikec 2023-06-29 15:06:46 +02:00 committed by GitHub
parent a41d5df60c
commit 77304b353e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
interface/app/$libraryId/Explorer/View/GridView.tsx
View file

@ -76,7 +76,7 @@ export default () => {
rowsBeforeLoadMore={explorerView.rowsBeforeLoadMore}
top={explorerView.top}
preventSelection={explorerView.isRenaming || !explorerView.selectable}
preventContextMenuSelection={!explorerView.contextMenu}
preventContextMenuSelection={explorerView.contextMenu === undefined}
>
{({ index, item: Item }) => {
const item = explorerView.items?.[index];

2
interface/app/$libraryId/Explorer/View/ListView.tsx
View file

@ -378,7 +378,7 @@ export default () => {
}
function handleRowContextMenu(row: Row<ExplorerItem>) {
if (!explorerView.onSelectedChange || !explorerView.contextMenu) return;
if (!explorerView.onSelectedChange || explorerView.contextMenu === undefined) return;
const itemId = row.original.item.id;

2
interface/app/$libraryId/Explorer/View/MediaView.tsx
View file

@ -68,7 +68,7 @@ export default () => {
rowsBeforeLoadMore={explorerView.rowsBeforeLoadMore}
top={explorerView.top}
preventSelection={!explorerView.selectable}
preventContextMenuSelection={!explorerView.contextMenu}
preventContextMenuSelection={explorerView.contextMenu === undefined}
>
{({ index, item: Item }) => {
if (!explorerView.items) {

2
interface/app/$libraryId/Explorer/View/index.tsx
View file

@ -101,7 +101,7 @@ export const ViewItem = ({ data, children, ...props }: ViewItemProps) => {
</div>
}
onOpenChange={explorerView.setIsContextMenuOpen}
disabled={!explorerView.contextMenu}
disabled={explorerView.contextMenu === undefined}
asChild={false}
>
{explorerView.contextMenu}

2
interface/app/$libraryId/Explorer/index.tsx
View file

@ -79,7 +79,7 @@ export default function Explorer(props: Props) {
rowsBeforeLoadMore={5}
selected={selectedItemId}
onSelectedChange={setSelectedItemId}
contextMenu={selectedItem && <ContextMenu item={selectedItem} />}
contextMenu={selectedItem ? <ContextMenu item={selectedItem} /> : null}
emptyNotice={
props.emptyNotice || (
<EmptyNotice

2
interface/app/$libraryId/overview/index.tsx
View file

@ -49,7 +49,7 @@ export const Component = () => {
onSelectedChange={setSelectedItemId}
top={68}
className={explorerStore.layoutMode === 'rows' ? 'min-w-0' : undefined}
contextMenu={selectedItem && <ContextMenu item={selectedItem} />}
contextMenu={selectedItem ? <ContextMenu item={selectedItem} /> : null}
/>
{explorerStore.showInspector && (