2017-06-27 00:32:38 +00:00
|
|
|
Please follow these pull request guidelines:
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
1. Update your fork to the latest upstream version.
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
2. Follow the coding conventions of the original source files (indentation, spaces, brackets layout).
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
3. Code changes must pass JSHint validation with the `.jshintrc` settings of this project.
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
4. Code changes must pass the QUnit tests defined in the `test` folder.
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
5. New features should be covered by accompanying QUnit tests.
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
6. Keep your commits as atomic as possible, i.e. create a new commit for every single bug fix or feature added.
|
2014-10-05 08:18:50 +00:00
|
|
|
|
2017-06-27 00:32:38 +00:00
|
|
|
7. Always add meaningful commit messages.
|
